Include "http://" in this PHP URL shortening code

Question

This is the code I currently have. How would I tweak it to include http:// in the href in the returned result every time? Currently, http:// is not in the returned result unless it's in the original string variable $text. I wish to have it added to the href if it is not in the original $text. Thanks!

function urlfixer($text){

   $pattern  = '#\b(([\w-]+://?|www[.])[^\s()<>]+(?:\([\w\d]+\)|([^[:punct:]\s]|/)))#';
   $callback = create_function('$matches', '
       $url       = array_shift($matches);
       $url_parts = parse_url($url);

       $text = parse_url($url, PHP_URL_HOST) . parse_url($url, PHP_URL_PATH);
       $text = preg_replace("/^www./", "", $text);

       $last = -(strlen(strrchr($text, "/"))) + 1;
       if ($last < 0) {
           $text = substr($text, 0, $last) . "&hellip;";
       }

       return sprintf(\'<a rel="nofollow" href="%s">%s</a>\', $url, $text);
   ');

   return preg_replace_callback($pattern, $callback, $text);
}

You can't just append it to the beginning when you return from the your function? — Jared Farrish
– Jared Farrish, Commented Mar 28, 2013 at 3:15

jszobody · Accepted Answer · 2013-03-28 03:21:27Z

2

Since you don't know if your $url has http:// on it or not just stick it on the beginning, and then make sure it's stripped just in case.

$url = 'http://' . str_replace('http://','',$url);
return sprintf('<a rel="nofollow" href="%s">%s</a>', $url, $text);

edited Mar 28, 2013 at 3:21

answered Mar 28, 2013 at 3:15

jszobody

29k6 gold badges66 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jim Over a year ago

I like the simplicity of this approach but it's probably a bit safer to only replace occurrences of http:// at the start of the string.

bobrobbob · Accepted Answer · 2013-03-28 03:24:44Z

1

$url       = array_shift($matches);
if( substr($url,0,6)!='http://' ) {
    $url='http://'.$url;
}

something like this should do it

answered Mar 28, 2013 at 3:24

bobrobbob

1,28111 silver badges21 bronze badges

Collectives™ on Stack Overflow

Include "http://" in this PHP URL shortening code

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related