Php url shortener with static htmls

Question

My htaccess:

RewriteEngine On
RewriteCond $1 !^(index\.php)
RewriteRule ^(.*)$ index.php?l=$1 [L]

and php:

<?php
$links = parse_ini_file('links.ini');

if(isset($_GET['l']) && array_key_exists($_GET['l'], $links)){
header('Location: ' . $links[$_GET['l']]);
}
else
    include ('index.html');
?>

In the links.ini I have short url and website url:

youtube1 = "https://www.youtube.com/watch?v=9bZkp7q19f0"
youtube2 = "https://www.youtube.com/watch?v=wcLNteez3c4"
etc.

These files are in the root and url shortening works.

In the index.html I have menu with static html pages:

<a href="/" >Home page</a>
<a href="page1" >page1</a>
<a href="page2" >page2</a>
etc.

But when I click on them it only reloads index.html?

Any help will be appriciated!

I tried to put static html links into links.ini:

page1 = page1

but that doesn't work either... I get the Page isn't redirecting properly error.

Have you tried var_dump($links);?

hjpotter92
– hjpotter92

2017-02-05 13:53:00 +00:00
Commented Feb 5, 2017 at 13:53 — hjpotter92
– hjpotter92, Commented Feb 5, 2017 at 13:53

Olaf Dietsche · Accepted Answer · 2017-02-05 15:06:38Z

1

When you look into error messages, you will notice

PHP Warning: syntax error, unexpected '=' in links.ini on line 1\n in /var/www/example.com/index.php on line 2

and when looking at links.ini, you will see a second equal sign = in the URL

youtube1 = https://www.youtube.com/watch?v=9bZkp7q19f0

So quoting the value, e.g.

youtube1 = "https://www.youtube.com/watch?v=9bZkp7q19f0"

should make it work as expected.

answered Feb 5, 2017 at 15:06

Olaf Dietsche

74.4k9 gold badges113 silver badges214 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jim34 Over a year ago

Thank you for this, I added the youtube links for an example. The problem that I am having is that it doesn't open the static htmls (menu) in the index.html. I think the htaccess rules might be the problem?

Olaf Dietsche Over a year ago

No, they are not. I copied your example files verbatim to my test environment, and it redirects to the appropriate youtube video when I enter http://www.example.com/youtube1 (after quoting in links.ini, of course). So the code works, and the problem is with either links.ini or index.html. Look into error.log for further hints.

Jim34 · Accepted Answer · 2017-02-05 19:55:29Z

0

So i changed the php to this:

<?php
$links = parse_ini_file('links.ini');

if(isset($_GET['l']) && array_key_exists($_GET['l'], $links)){
header('Location: ' . $links[$_GET['l']]);
}

else if($_GET['l'] == 'index' | $_GET['l'] == 'page1' | $_GET['l'] == 'page2')
    include($_GET['l']. '.html');

else if($_GET['l'] == '')
    include('index.html');

else 
    include('404.html');

?>

I don't know how elegant this is... If someone knows a better way...

answered Feb 5, 2017 at 19:55

Jim34

455 bronze badges

Comments

Uri Goren · Accepted Answer · 2018-04-20 01:10:14Z

0

You might want to look at this simple url shortener, it's very similar to what you are doing, but with a json instead of an ini file.

The core is the .htaccess file:

Options +SymLinksIfOwnerMatch
RewriteEngine on
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^((?!index\.php).+)$ /index.php?short=$1 [NC,L,QSA]

answered Apr 20, 2018 at 1:10

Uri Goren

13.8k8 gold badges62 silver badges113 bronze badges

Collectives™ on Stack Overflow

Php url shortener with static htmls

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related