php regex replace image tags

Question

I need replace image tags with smiles to {smile:smilename}

   <?php
    $pattern = '<img src="/img/smile/(.*?).gif">';
    $replacement = '{smile:$1}';
    $subject = '<div contenteditable="true" id="message_text">text<img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"><img src="/img/smile/smile3.gif"></div>';
    echo preg_replace($pattern, $replacement, $subject, -1 );
    ?>

I get:

<div contenteditable="true" id="message_text">text<{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}><{smile:smile3}></div>

<{smile:smile3}>

but i need

{smile:smile3}

You should parse the HTML first and then manipulate the src attributes of img elements. You're trying to parse HTML with regex, and that's not a good idea. — Justin Morgan
– Justin Morgan, Commented Aug 21, 2013 at 13:51

MDEV · Accepted Answer · 2013-08-21 13:55:19Z

9

Your < and > are being treated as delimiters, instead of part of the expression. Use:

$pattern = '#<img src="/img/smile/(.*?).gif">#';

See the php.net regexp delimiters documentation (third code example, and top user note)

edited Aug 21, 2013 at 13:55

answered Aug 21, 2013 at 13:45

MDEV

10.9k2 gold badges35 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

MDEV Over a year ago

Someone care to explain why they think this correct answer is incorrect?

h2ooooooo Over a year ago

My guess is that someone thinks that slashes have to be escaped, or that the delimiter has to be a slash which is completely wrong.

Segabond Over a year ago

I just realised that < > pair cannot be delimiters, they are different. His code just does not make any sense. It would not work at all.

Amal Over a year ago

Nice catch! Also, +1!

MDEV Over a year ago

@Segabond actually, you can use paired delimiters, not just repeated characters i.e. [expr] or {expr} not just /expr/

|

Segabond · Accepted Answer · 2013-08-21 13:50:26Z

6

You need to use a delimiting characters in your pattern and escape this character inside.

$pattern = '/<img src="\/img\/smile\/(.*?).gif">/';

Or

$pattern = '@<img src="/img/smile/(.*?).gif">@';

edited Aug 21, 2013 at 13:50

answered Aug 21, 2013 at 13:46

Segabond

1,14312 silver badges16 bronze badges

Collectives™ on Stack Overflow

php regex replace image tags

2 Answers 2

7 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related