Overflow Exception. StringBuilder

Question

I am trying to convert a StringBuilder into an Int64 but I get Overflow Exception and I cannot figure out why. The length of the string is not greater than the int. My current code is:

+ $exception {"Value was either too large or too small for an Int64."} System.Exception {System.OverflowException}

private static Int64 EightBit(string Data)
{
  StringBuilder Pile = new StringBuilder();
  char[] values = Data.ToCharArray();
  foreach (char letter in values)
   {
    // Get the integral value of the character. 
    int value = Convert.ToInt32(letter);
    // Convert the decimal value to a hexadecimal value in string form. 
    string hexOutput = String.Format("{0:X}", value);
    Pile.Append(Convert.ToString(Convert.ToInt32(hexOutput, 16), 2));
   }
  return Convert.ToInt64(Pile.ToString()); //Error here
 }

Please provide minimal sample - you really need one line for this post like Convert.ToInt64("8765432187654321")... after you have such sample you may be able to answer yourself... — Alexei Levenkov
– Alexei Levenkov, Commented Jul 30, 2014 at 4:45
What are you trying to achieve in this code? All those Converts seems overcomplicated... What I see that you are trying to create Int64 from binary representation stored in strng... Maybe you forgot to add 2 in Convert.ToInt64(Pile.ToString(), 2) — Konrad Kokosa
– Konrad Kokosa, Commented Jul 30, 2014 at 4:48
And not sure if you really want int value = Convert.ToInt32(letter); as you are using ASCII value of character, so 0 becomes 48, not 0. — Konrad Kokosa
– Konrad Kokosa, Commented Jul 30, 2014 at 4:55

dbc · Accepted Answer · 2014-07-30 04:59:44Z

1

You are converting the ASCII values of a string to their binary values (Convert.ToString(string, 2) converts to base 2, right?)

character -> ASCII value -> Hex string representation -> Int Value -> Binary string representation of int value -> try to parse that string in base 10.

For instance, if "Data" is "147483647", then "Pile" is "110001110100110111110100111000110011110110110100110111" which is clearly larger than 'long.MaxValue' in base 10. By converting each character in a string to the binary representation of their ASCII values, you are creating a number string with far, far more digits than originally when you finally to to parse it base 10.

Just a quick step-through in the debugger should confirm the problem.

answered Jul 30, 2014 at 4:59

dbc

120k27 gold badges273 silver badges404 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Overflow Exception. StringBuilder

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related