system.outofmemoryexception in StringBuilder

Question

I have following code:

for (int i = 0; i < ds.Tables[0].Rows.Count; i++)
{
    for (int j = 0; j < ds.Tables[0].Columns.Count; j++)
    {
        strCsv.Append( XC.CleanForCsv(ds.Tables[0].Rows[i][j].ToString()) + ",");
    }

    strCsv.Append( "\r\n" + strCsv)
}

Dataset contains 8000 records. Looping through the records using a for loop after only 15 records strCsv.Append( "\r\n" + strCsv) statement throws an exception saying System.OutOfMemoryException. What is the reason behind this exception?

Note for future questions - please pay more attention to formatting your code nicely. I'll edit the question now to show how it should have been posted to start with, but please do it on your initial post in future. — Jon Skeet
– Jon Skeet, Commented Jul 30, 2013 at 7:18

Jon Skeet · Accepted Answer · 2013-07-30 07:17:17Z

13

Look at this:

strCsv.Append( "\r\n" + strCsv)

You're doubling the output on every iteration. That will build up very quickly - as well as giving you the wrong results.

I think you just want:

strCsv.Append("\r\n");

answered Jul 30, 2013 at 7:17

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

system.outofmemoryexception in StringBuilder

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related