Angularjs error when calling factory method

Question

I am new to angularjs. I am trying to call a function in a factory but I am getting the below error,

Error: [$injector:undef] Provider 'todoStorage' must return a value from $get factory method.

This is my factory,

todomvc.factory('todoStorage', function ($q,$http) {
var STORAGE_ID = 'todos-angularjs-perf';

 function get(){
            var promise = $q.defer();

            $http.get('http://localhost/test.php').success(function(data){
                    promise.resolve(data);
            });

            return promise.promise;
        }

});

And this is how I call the function,

var todos = $scope.todos = todoStorage.get();

What exactly is happening and why this error coming up?

TGH · Accepted Answer · 2014-11-21 04:54:01Z

4

todomvc.factory('todoStorage', function ($q,$http) {
var STORAGE_ID = 'todos-angularjs-perf';


 function get(){

   return $http.get('http://localhost/test.php');
 }

 return{get:get};

});

//call the service like this
todoStorage.get().then(function(res){
  $scope.todos = res.data;
});

Your code is not returning the actual service factory. Since you are using factory you have return some JavaScript object pointing to your internal function. Otherwise it's not a valid factory, and your external code will have no way of getting to the internal get function.

edited Nov 21, 2014 at 4:54

answered Nov 21, 2014 at 3:53

TGH

39.4k13 gold badges106 silver badges140 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

John Nick Over a year ago

The error is resolved, but why I am not getting the data. The promise is returning null. Does defer make the call synchronous?

TGH Over a year ago

I recommend that you resolve the promise on the calling side instead of inside the service. Also, based on the implementation of $q, promises will never behave synchronously, even if the promise is resolved immediately.

TGH Over a year ago

I would not create a new promise here. It's easier to just return the original promise generated by $http.

John Nick Over a year ago

I tried to access the data after calling the service as u mentioned. But only the promise object is getting printed.

Collectives™ on Stack Overflow

Angularjs error when calling factory method

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related