Cannot call Factory in Controller (angularjs)

Question

I am staring to learn angularjs (please be kind).

I am trying to call generatePollCode method in the factory using the createCtrl but I got the message below:

Error: [$injector:undef] http://errors.angularjs.org/1.6.4/$injector/undef?p0=pollFactory...

Here's my code:

App initialization:

var app = angular.module("pollApp", ['ngRoute', 'ngAnimate']);

Factory:

app.factory("pollFactory", function($http){

var factory = {};

factory.generatePollCode = function(){
    var text = "";
    var possible = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";

    for( var i=0; i < 5; i++ ){
        text = text + possible.charAt(Math.floor(Math.random() * possible.length));
    }

    return text;
  };

});

Controller:

 app.controller('createCtrl', function($http, $scope, $timeout, focus, pollFactory){
  $scope.submitPoll = function (){
      var x =pollFactory.generatePollCode();
      console.log(x);
  }
});

Thanks for anyone that can help me!

where is the factory located??in the same js file where ur controler located???if not have add that scrip to index — Sa E Chowdary
– Sa E Chowdary, Commented May 6, 2017 at 11:21
Yes, the factory and the controller files are in the same folder — Zyx Sun
– Zyx Sun, Commented May 6, 2017 at 11:22

Hadi · Accepted Answer · 2017-05-06 11:25:18Z

3

It should be like this. you forgot return factory object

app.factory("pollFactory", function($http){
 var factory = {};
 factory.generatePollCode = function(){
  var text = "";
  var possible = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";

  for( var i=0; i < 5; i++ ){
     text = text + possible.charAt(Math.floor(Math.random() * 
     possible.length));
   }
    return text;
 };
 return factory 
});

answered May 6, 2017 at 11:25

Hadi

17.3k4 gold badges41 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Zyx Sun Over a year ago

Thank you! I forgot to read the docs thoroughly and missed that part.

Hadi Over a year ago

You are welcome. glad to help you. please accept the answer. thanks :)

Collectives™ on Stack Overflow

Cannot call Factory in Controller (angularjs)

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related