How do I store an array of strings into another array of strings?

Question

I'm trying to store my old array of struct type that holds first names of people into a new string array that has been downsized so I can then shuffle it round in another method.

string[] newStringArray = new string[10]

for (int i = 0; i < oldStringArray.Length; i++)
{    
    newStringArray = oldStringArray[i].firstName;//Cannot convert type 'string to 'string[]'
}

foreach (string value in newStringArray)
{
    Console.WriteLine(value);
}

It's not clear what you are trying to achieve, you are defining a new array with ten elements but then enumerating over all the old elements. Do you want newStringArray to contain the first ten firstnames of oldStringArray? — DanL
– DanL, Commented Jun 13, 2015 at 8:18
Yes I do want my newStringArray to contain the first ten names of oldStringArray. — Daniel
– Daniel, Commented Jun 13, 2015 at 8:20
You set the whole array, just use the indexer newStringArray[i] = oldStringArray[i].firstName; — Ahmad Ibrahim
– Ahmad Ibrahim, Commented Jun 13, 2015 at 8:21
Change your loop condition from i < oldStringArray.Length to (i < oldStringArray.Length && i < newStringArray.Length) — DanL
– DanL, Commented Jun 13, 2015 at 8:26

cbr · Accepted Answer · 2015-06-13 08:26:28Z

6

It looks like you forgot the index accessor:

string[] newStringArray = new string[10];
for (int i = 0; i < oldStringArray.Length && i < newStringArray.Length; i++)
{
    newStringArray[i] = oldStringArray[i].firstName;
    //             ^
}

edited Jun 13, 2015 at 8:26

answered Jun 13, 2015 at 8:23

cbr

13.8k3 gold badges43 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

DanL Over a year ago

If oldStringArray contains more than 10 elements you would then get an index out of bounds exception when accessing newStringArray[10]

Yuval Itzchakov · Accepted Answer · 2015-06-13 08:11:16Z

3

You can project your FirstName properties using Enumerable.Select, and then materialize them into a new array using Enumerable.ToArray:

string[] firstNames = oldStringArray.Select(x => x.FirstName).ToArray();

answered Jun 13, 2015 at 8:11

Yuval Itzchakov

150k32 gold badges275 silver badges333 bronze badges

Comments

Ahmad Ibrahim · Accepted Answer · 2015-06-13 08:25:18Z

2

You have to declare the new array with the same size as the old one.

string[] newStringArray = new string[oldStringArray.Length];

Then use the indexer to set the elements of the new array.

for (int i = 0; i < oldStringArray.Length; i++)
{    
    newStringArray[i] = oldStringArray[i].firstName;
}

answered Jun 13, 2015 at 8:25

Ahmad Ibrahim

1,9352 gold badges15 silver badges33 bronze badges

Comments

DanL · Accepted Answer · 2015-06-13 08:23:19Z

0

If you want only the first ten firstnames then use

var firstTenFirstNames = oldStringArray.Select(x => x.FirstName).Take(10).ToArray()

answered Jun 13, 2015 at 8:23

DanL

2,01415 silver badges15 bronze badges

Collectives™ on Stack Overflow

How do I store an array of strings into another array of strings?

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related