Shuffling string array only use each one once

Question

I have an array of strings, which will be placed into the text of a button, it is shuffling the array correctly but when it comes to placing the text inside of the button it is replacing them all with the same value and has no way of knownig whether the value has already been used or no t, I'm guessing this is down to the loops being in the wrong position or something of that nature.

protected void Page_Load(object sender, EventArgs e)
{

    string[] arr = new string[]
    {
        "0","1","2","3","4","5","6","7","8","9"
    };
    //shuffle code

    string[] shuffle = RandomStringArrayTool.RandomizeStrings(arr);
    foreach (string s in shuffle)
    {   
        foreach (var item in panel1.Controls)
        {
            if (item is Button)
            {  
                ((Button)item).Text = s.ToString();
            }
        }
    }


}

Is your RandomStringArrayTool class from here: dotnetperls.com/shuffle ? — STLDev
– STLDev, Commented Jan 23, 2015 at 4:32

chouaib · Accepted Answer · 2015-01-23 05:19:19Z

3

yes you are calling foreach twice! it does the second foreach for all the strings of shuffleso ending with all the buttons named with the value of shuffle[9]

change it to :

int i=0;
foreach (var item in panel1.Controls)
{
    if (item is Button)
    {  
        ((Button)item).Text = shuffle[i];
        i++;
    }
}

EDIT

You can get rid of RandomStringArrayTool thing, and implement your own, this is an easy way to start of:

string str = "0123456789";
bool[] used = new bool[10];
Random r = new Random();

foreach (var item in shuffle_gbx.Controls)
{
    // keep looking for unused index
    int i = r.Next(0,10);
    while (used[i])
    {
       i = r.Next(0, 10);
    }

    ((Button)item).Text = str[i].ToString();
    used[i] = true;
 }

edited Jan 23, 2015 at 5:19

answered Jan 23, 2015 at 4:35

chouaib

2,8175 gold badges23 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Shuffling string array only use each one once

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related