Optimize if condition javascript

Question

I am just a newbie in javascript, this is how i am writing if condition in a javascript,

function setAccType(accType) {
    if (accType == "PLATINUM") {
        return "Platinum Customer";
    } else if (accType == "GOLD") {
        return "Gold Customer";
    } else if (accType == "SILVER") {
        return "Silver Customer";
    }
},

Is there a better way to do it?

The comma after function is not required

Tushar
– Tushar

2015-10-21 05:50:20 +00:00
Commented Oct 21, 2015 at 5:50 — Tushar
– Tushar, Commented Oct 21, 2015 at 5:50

CD.. · Accepted Answer · 2015-10-21 05:54:13Z

6

You can use an object as a map:

function setAccType(accType){
  var map = {
    PLATINUM: 'Platinum Customer',
    GOLD: 'Gold Customer',
    SILVER: 'Silver Customer'
  }

  return map[accType];
}

Or as @Tushar pointed out:

var accountTypeMap = {
  PLATINUM: 'Platinum Customer',
  GOLD: 'Gold Customer',
  SILVER: 'Silver Customer'
}

function setAccType(accType){  
  return accountTypeMap[accType];
}

edited Oct 21, 2015 at 5:54

answered Oct 21, 2015 at 5:48

CD..

74.4k25 gold badges160 silver badges170 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tushar Over a year ago

map can be moved outside of the function

Shanimal · Accepted Answer · 2015-10-21 05:50:29Z

2

var TYPES = {
  "PLATINUM":"Platinum Customer",
  "GOLD":"Gold Customer",
  "SILVER":"Silver Customer"
}

function getType(acctType){
    return TYPES[acctType];
}

answered Oct 21, 2015 at 5:50

Shanimal

11.8k7 gold badges67 silver badges82 bronze badges

Comments

Tushar · Accepted Answer · 2015-10-21 05:57:40Z

2

Assuming accType will always be passed to function.

Convert the string to first capital and other small case
Append Customer to it

Code:

return accType[0] + accType.slice(1).toLowerCase() + ' Customer';

Code Explanation:

accType[0]: Get the first character of the string
accType.slice(1).toLowerCase(): Get the string except first character

edited Oct 21, 2015 at 5:57

answered Oct 21, 2015 at 5:47

Tushar

87.4k21 gold badges164 silver badges182 bronze badges

Comments

Moishe Lipsker · Accepted Answer · 2015-10-21 05:49:37Z

1

Try using the switch block if you are comparing the same variable against different values and having different things happen in different cases:

function setAccType(accType){
    switch(accType) {
        case "PLATINUM" :
            return "Platinum Customer";
        case "GOLD":
            return "Gold Customer";
        case "SILVER":
            return "Silver Customer";
     }
 }

answered Oct 21, 2015 at 5:49

Moishe Lipsker

3,0322 gold badges24 silver badges29 bronze badges

Collectives™ on Stack Overflow

Optimize if condition javascript

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related