Optimize conditional expression inside if statement

Question

I have below piece of conditional block in Javascript. I optimized it to the level possible by me, but I feel that it can still be more optimized.

Can someone please suggest a better way to write below code.

if(flag) {
  this.flag = flag; /* some assignment*/
  oldSearchType = newSearchType ? newSearchType : oldSearchType; /*Any better way to write this?*/
}

Denys Séguret · Accepted Answer · 2016-03-09 08:44:03Z

4

You could write the second part like this:

oldSearchType = newSearchType || oldSearchType;

which most of us would find clearer. The global if(flag) { condition is clear enough.

answered Mar 9, 2016 at 8:44

Denys Séguret

384k90 gold badges813 silver badges780 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bata · Accepted Answer · 2016-03-09 08:53:45Z

1

I find the most obvious solution also the most clear:

if (newSearchType) {
    oldSearchType = newSearchType;
}

answered Mar 9, 2016 at 8:53

Bata

6513 silver badges7 bronze badges

Collectives™ on Stack Overflow

Optimize conditional expression inside if statement

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related