Finding matching strings in a String array

Question

I'm having trouble extracting the names that contain more than 3 "O" or "o" in them from a string array. I have to print them after. Where did I go wrong and how can I fix it?

static String[] towns = {"England", "France",
    "Romania", "Germany", "Canada", "Russia",
      "Eoeoeooero"};

 public static void main(String[] args) {


    for (int i = 0; i < towns[i].length(); i++) {



            for (int j = 0; j < towns[i].length(); j++) {
                if (towns[i].charAt(j) == 'o' || towns[i].charAt(j) == 'O') {
                    e++;
                }
            }

            if (e > 3) {
                System.out.println(towns[i]);
            }
        }
    }

}

What's not working? What happens when you run your code? What output/results are you seeing? — nicomp
– nicomp, Commented Dec 12, 2015 at 14:36

Sergey Kalinichenko · Accepted Answer · 2015-12-12 14:55:33Z

1

Since you are missing the declaration of variable e, I assume that it is declared in the scope of the class. This is a bad idea, because it becomes shared among all methods running on the same instance, or among all methods if it is static.

Make variable e local to your method, and move it into the scope of your for loop to fix the problem:

for (int i = 0; i < towns.length(); i++) {
    int e = 0; // <<== Here
    for (int j = 0; j < towns[i].length(); j++) {
        if (towns[i].charAt(j) == 'o' || towns[i].charAt(j) == 'O') {
            e++;
        }
    }
    if (e > 3) {
        System.out.println(towns[i]);
    }
}

edited Dec 12, 2015 at 14:55

answered Dec 12, 2015 at 14:36

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

vlad Over a year ago

Even with variable e there im still getting nothing - print doesn't give anything run: BUILD SUCCESSFUL (total time: 0 seconds)

Sergey Kalinichenko Over a year ago

@vlad You need to replace towns[i].length() with towns.length() in the outer loop. I assume it's a typo, though.

Barna Danko · Accepted Answer · 2015-12-12 14:44:24Z

0

You have an uninitialized variable "e", which can cause a compile time error.

Also your first for loop for (int i = 0; i < towns[i].length(); i++) should be going through the elements of String[] towns, but what you wrote is using the length of a member of the array.

for (int i = 0; i < towns.length(); i++){
    int e = 0;
....

answered Dec 12, 2015 at 14:44

Barna Danko

112 bronze badges

Collectives™ on Stack Overflow

Finding matching strings in a String array

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related