How to Search a string array for specific strings

Question

I am trying to search an array for a couple of specific strings that I get from words in a sentence. Eventually this sentence will be in-putted by the user but I have hard coded it in at the moment to make testing easier.If the program finds the strings it should return with "Yes" and "No" if it doesn't. The problem is that I am getting yes all the Time.

public class main {
public static void main(String[]args)
{

    String Sentence = "This is a sentence";
    String[] CensorList =
        {"big","head"};

    String[] words = Sentence.split(" ");
    System.out.println(words.length);
    boolean match = false;

    for(int i = 0; i < words.length; i++)
    {
        for (int j = 0; j < CensorList.length; j++)
        {
            if(words[i].equals(CensorList[j]))
            {
                match = true;
        }else{
            match = false;
        }
    }

    }
    if (match = true){
        System.out.println("Yes");}
    else{
        System.out.println("No");
}

} }

I would really appreciate any help with this one, Thanks in advance.

haven't checked your code but you definitely wanna remove that ';' after if().. — Purush Pawar
– Purush Pawar, Commented Apr 25, 2013 at 13:20

duffy356 · Accepted Answer · 2013-04-25 14:36:52Z

2

the if in your second for() has wrong braces.

try this one:

for (int j = 0; j < CensorList.length; j++)
{
    if(words[i].equals (CensorList[j])) {
        match = true;
        System.out.println("Yes");
    } else {
        System.out.println("No");
    }
    match = false;
}

for your second try:

the

if (match = true)

does not compare match with true, it sets the match flag to true, which results always in true.

compare the flag in your if:

if (match == true) // or simply if (match)
{ ....

edited Apr 25, 2013 at 14:36

answered Apr 25, 2013 at 13:18

duffy356

3,7163 gold badges35 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user1048104 Over a year ago

Thanks this worked great, I have updated my code to print out the yes/no message only once. But its back to only printing yes again. I don't suppose you could point me in the right direction with this error. Sorry for the hassle.

duffy356 Over a year ago

check my answer, it might be interresting for you ;)

user123454321 · Accepted Answer · 2013-04-25 13:18:40Z

1

Try it:

for(int i = 0; i < words.length; i++)
{
    for (int j = 0; j < CensorList.length; j++)
    {
        if(words[i].equals (CensorList[j])) 
            match = true;
    }
            if (match) {
                System.out.println("Yes"); }
            else {
                System.out.println("No"); }
            match = false;
}

answered Apr 25, 2013 at 13:18

user123454321

1,0589 silver badges29 bronze badges

Comments

LionC · Accepted Answer · 2013-04-25 13:19:22Z

1

I think you have some typos in here.

    for (int j = 0; j < CensorList.length; j++)
    {
           if(words[i].equals (CensorList[j]));
    }

This will do essentially nothing, as the if has nothing to do if the expression is evaluated to true. Then after the loop you set match to true, so it will be true always, and it will always print "Yes"

answered Apr 25, 2013 at 13:19

LionC

3,1061 gold badge24 silver badges31 bronze badges

Comments

Arun P Johny · Accepted Answer · 2013-04-25 13:20:45Z

1

You can use a simple RegEx based solution for this

private static boolean test(String value) {
    String[] CensorList = { "This", "No" };

    for (String string : CensorList) {
        Pattern pattern = Pattern.compile("\\b" + string + "\\b", Pattern.CASE_INSENSITIVE);
        if (pattern.matcher(value).find()) {
            return true;
        }
    }
    return false;
}

Then

String string = "This is a sentence";
if(test(string)){
    System.out.println("Censored");
}

answered Apr 25, 2013 at 13:20

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Comments

Miquel · Accepted Answer · 2013-04-25 13:17:51Z

0

Any reason you are not using String.indexOf(String) ?

Another issue is if you are doing this repeatedly for the same (very large) stirng in which case, you might want to look into more sophisticated algorithms like suffix trees or even use specialized software like Apache Lucene

answered Apr 25, 2013 at 13:17

Miquel

15.7k8 gold badges56 silver badges88 bronze badges

Comments

Antoine · Accepted Answer · 2013-04-25 13:20:04Z

0

Try to use

public class main {
public static void main(String[]args)
{

    String Sentence = "This is a sentence";
    String[] CensorList =
        {"This","No"};

    String[] words = Sentence.split(" ");
    System.out.println(words.length);
    boolean match = false;

    for(int i = 0; i < words.length; i++)
    {
        for (int j = 0; j < CensorList.length; j++)
        {
            if(words[i].compareTo(CensorList[j])==0)
            {
                System.out.println("Yes");
            }
            else{System.out.println("No");}

        }
    }

}

answered Apr 25, 2013 at 13:20

Antoine

5584 silver badges13 bronze badges

Collectives™ on Stack Overflow

How to Search a string array for specific strings

6 Answers 6

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related