Will I be ok doing this?
foreach ($item as $val)
{
include('external_script.php');
}
Where external script is about 800 lines of code I want to keep separate for organizational sakes.
Gracious!
-
5........ So, I'm maintaining a 30,000 line pile of slop where the programmer does this all the time. If you are him, may I punch you through the internet?Incognito– Incognito2010-08-06 16:23:49 +00:00Commented Aug 6, 2010 at 16:23
-
@Incognito, You mean 30k lines in a single file or do you mean a total of 30k lines?Pacerier– Pacerier2015-03-06 09:15:49 +00:00Commented Mar 6, 2015 at 9:15
Add a comment
|
5 Answers
I guess you should better use a function for this.
Including a file requires to read, parse, and interpret the file. But if you have a function that you just feed with the current $item, it its code is just read, parsed and interpreted once and you won’t have that overhead you would have with including.
5 Comments
atwellpub
A problem I see with making it a function would be having to pass variables into the function, and there are 80+ variables that the LOC use.
Gumbo
@atwellpub: Are these all variables that are defined somewhere before?
ladenedge
Encapsulate all of those variables in a class? It definitely sounds like there are some design problems here.
Your Common Sense
@atwellpub the more details coming, the worse it seems. why not to tell us the whole story at once, instead of feedeng by small chunks?
atwellpub
I would need to learn how to encapsulate variables in a class, then a function sounds to be the best solution. Will there be any speed difference between a function and include_once?
It will work but there's a disk I/O overhead for calling an external file in a loop unless you happen to have APC, XCache, eAccelerator running. Besides, you can't use include. You should be using include_once if it's the same file you're reloading
You wound not be killed by a god for doing that, and it would even work. But still function is better.
Comments
Whether you will be okay or not depends on if you want to include your external script in each iteration or not.
Note that if your included file contains functions, you will end up with errors for trying to define the same function multiple times.
answered Aug 6, 2010 at 15:55
Daniel Vandersluis
94.7k23 gold badges174 silver badges158 bronze badges
Comments
ermmmm - why?
if its the same file include it once - perhaps put the code in it in a function and just call that function how ever many times you need to.
