Bash Array Key from User Input

Question

So I have a bash script which will scan a directory and run a function on a selected input.

    echo -n "
-------------------------------------------------------
            `hostname` Menu
-------------------------------------------------------

Choose your desired Host:
`
i=1
for D in /var/www/*.*/;
    do   
        if [[ -d $D ]]; then
            Hosts[$i]=$D
            echo $i') ' $D
            i=$(($i+1))
        fi
    done
    `
"
read -p "Select: " Input
    Directory="${Hosts[$Input]}";
    ChangePerms;

It seems that for some reason, the key is not setting from the array properly.

Choose your desired Host:
1)  /var/www/example1.com/
2)  /var/www/example2.com/
+ read -p 'Select: ' Input
Select: 1
+ Directory=
+ ChangePerms
+ true

What am I missing? All help is much appreciated!

EDIT: As a side note, I can run the commands separately and get results.

root@web005:/# i=1
root@web005:/# for D in /var/www/*.*/;
>     do
>         if [[ -d $D ]]; then
>             Hosts[$i]=$D
>             echo $i') ' $D
>             i=$(($i+1))
>         fi
>     done
1)  /var/www/example1.com/
2)  /var/www/example2.com/
root@web005:/# read -p "Select: " Input
Select: 1
root@web005:/# Directory="${Hosts[$Input]}";
root@web005:/# echo $Directory
/var/www/example1.com/
root@web005:/#

Here is the working code for those who get stuck like me:

echo -n "
-------------------------------------------------------
            `hostname` Menu
-------------------------------------------------------

Choose your desired Host:

"
i=1
for D in /var/www/*.*/;
    do   
        if [[ -d $D ]]; then
            Hosts[$i]=$D
            echo $i') ' $D
            i=$(($i+1))
        fi
    done
read -p "Select: " Input
    Directory="${Hosts[$Input]}";
    ChangePerms;

David C. Rankin · Accepted Answer · 2015-12-30 20:35:17Z

5

Your problem is:

`
i=1
for D in /var/www/*.*/;
    do   
        if [[ -d $D ]]; then
            Hosts[$i]=$D
            echo $i') ' $D
            i=$(($i+1))
        fi
    done
`

which executes in a subshell. Therefore, the remainder of your script has no idea what Hosts is. (in other words, Hosts is empty in the main body of your script). Fill Hosts before you present your menu.

answered Dec 30, 2015 at 20:35

David C. Rankin

85.1k6 gold badges67 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

LEXmono Over a year ago

Genius! I would upvote if I had the reputation to do so! Thank you! Edited code with working example.

John Hascall · Accepted Answer · 2015-12-30 20:39:44Z

1

Your quoting seems odd to me. This seems to work:

#!/bin/sh
echo -n "
-------------------------------------------------------
            `hostname` Menu
-------------------------------------------------------

Choose your desired Host:
"
i=1
for D in /tmp/www/*.*/ ; do   
        if [[ -d $D ]]; then
                Hosts[$i]=$D
                echo $i') ' $D
            i=$(($i+1))
        fi
    done
read -p "Select: " Input
Directory="${Hosts[$Input]}";
echo $Directory

answered Dec 30, 2015 at 20:39

John Hascall

9,4446 gold badges51 silver badges73 bronze badges

1 Comment

LEXmono Over a year ago

This was the simplest edit to make the answer by @david-c-rankin work! Thank you! I had the funny quotation, because I used to have a static case statement but I wanted this to be portable across all of my servers!

Collectives™ on Stack Overflow

Bash Array Key from User Input

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related