PHP Associative Array Variable Assignment

Question

I have this code in a larger function that pulls data from an HTTP Post (using Laravel) and puts it into an array for further processing. I feel like there has to be a better way to accomplish putting these fields into an array, but I'm not sure how. Suggestions?

    $fields = array(
        'env' => $request->get('env'),
        'subtype' => $request->get('subtype'),
        'submitter' => $request->get('submitter'),
        'problemSummary' => $request->get('problemSummary'),
        'problemDescription' => $request->get('problemDescription'),
        'resolutionCode' => $request->get('resolutionCode'),
        'resolutionDetails' => $request->get('resolutionDetails'),
        'status' => $request->get('status'),
        'account' => $request->get('account'),
        'phone' => $request->get('phone'),
        'residenceHall' => $request->get('residenceHall'),
        'roomNumber' => $request->get('roomNumber'),
        'buildingName' => $request->get('buildingName'),
        'buildingNumber' => $request->get('buildingNumber'),
        'source' => $request->get('source'),
        'submittedVia' => $request->get('submittedVia'),
        'internalNotes' => $request->get('internalNotes'),
        'computerType' => $request->get('computerType'),
        'computerVendor' => $request->get('computerVendor'),
        'operatingSystem' => $request->get('operatingSystem'),
        'recentBackup' => $request->get('recentBackup'),
        'antiVirus' => $request->get('antiVirus'),
        'acceptAgreement' => $request->get('acceptAgreement'),
    );

@FirstOne Yes, there is a $request->all() method but in case of errors from the posting side (extraneous fields, for example) I need to make sure I get only these fields. ->all() will send me everything. — Ross
– Ross, Commented Jul 18, 2016 at 23:23
@SverriM.Olsen This works, but at least in my opinion, seems messy. I was considering a loop like zerkms suggested. — Ross
– Ross, Commented Jul 18, 2016 at 23:24
@Ross What is the problem? The code may seem quite "bulky", if you like, but it tells you exactly what is happening. A loop would only complicate it. It is always better for code to be straight-forward than for it to do "clever" things because it looks better. — Sverri M. Olsen
– Sverri M. Olsen, Commented Jul 18, 2016 at 23:30

Ultimater · Accepted Answer · 2016-07-18 23:45:15Z

4

What's wrong with:

$fields = $request->only('env', 'subtype', 'submitter', ... );

or:

$fieldNames = ['env', 'subtype', 'submitter', ...];
$fields = $request->only($fieldNames);

answered Jul 18, 2016 at 23:45

Ultimater

4,7482 gold badges32 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

FirstOne Over a year ago

This looks better than my approach. +1

Ross Over a year ago

I had no idea this was a thing! This looks perfect. Thanks!

FirstOne · Accepted Answer · 2016-07-18 23:31:23Z

2

You could do something like this:

// Define the field names you want to get from the request
/*
$fields = array(
    'env',
    'subtype',
    'submitter',
    ...
);
*/

$data = array();
foreach($fields as $v){
    $data[$v] = $request->get($v);
}

It will only get the values from the keys of the request defined in $fields and it will put in the same key in the $data array.

edited Jul 18, 2016 at 23:31

answered Jul 18, 2016 at 23:26

FirstOne

6,2857 gold badges28 silver badges48 bronze badges

Collectives™ on Stack Overflow

PHP Associative Array Variable Assignment

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related