Create a variable for each array item

Question

I have the following code for my post sign up page on my site.

$email = $request['email'];
$username = $request['username'];
$password = bcrypt($request['password']);
$mmail = $request['mmail'];
$terms = $request['terms'];

$user = new User();

$user->email = $email;
$user->username = $username;
$user->password = $password;
$user->mmail = $mmail;
$user->terms = $terms;

$user->save();

I need to know if it is possible to simplify my code incase I add new sign up options. What I'm trying to do is create a variable for each item in the $request array which can then be used by the $user->sqltable = $sqltableitem

Something like

foreach ($REQUESTITEM?? as $???){
   ???
}

Is this possible and any other suggestions?

Glorfindel · Accepted Answer · 2021-10-26 05:48:57Z

2

You don't need to create a variable for each element. Just use mass assignment feature:

$user = User::create($request->all());

One this clause does exactly the same as all your posted code.

Don't forget to fill $fillable array:

class User extends Model
{
    protected $fillable = ['email', 'username', 'password', 'mmail', 'terms'];
}

If you want to bcrypt password manually, the right way to do this will be creating mutator:

class User extends Model
{
    public function set setPasswordAttribute($value)
    {
        $this->attributes['password'] = bcrypt($value);;
    }
}

edited Oct 26, 2021 at 5:48

Glorfindel

22.8k13 gold badges97 silver badges124 bronze badges

answered May 11, 2016 at 13:22

Alexey Mezenin

164k27 gold badges309 silver badges287 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

mateos Over a year ago

Does this also bcyrpt my passwords?

Alexey Mezenin Over a year ago

@Albert, I don't know which auth system do you use, but if you need to do that manually, use mutators (check the updated answer).

mateos Over a year ago

I did this before the clause and it works perfectly $request['password'] = bcrypt($request['password'] , No need for that other bit. I've edited the question so can you accept it

Alexey Mezenin Over a year ago

@Albert, thanks for suggestion, but the right way to do that kind of stuff is to use mutators. You controllers should be tiny and Model related logic should be in a Model.

mateos Over a year ago

You're right, I'll try have a shot with the mutators

Collectives™ on Stack Overflow

Create a variable for each array item

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related