Adding multiple TextViews into LinearLayout dynamically

Question

I have a problem with adding TextViews dynamically. I want to add hired rooms from list by method getRoomList() at first, and after that add rooms with text ": Free", which are in the existingRoomNames array but are not hired.

public void checkRoomsAndDate() {
    linearLayout = (LinearLayout) findViewById(R.id.linear1);
    linearLayout.removeAllViews();
    for (Room room : mCalendarModel.mList.getRoomList()) {
        addHiredRoomToLayout(room);
    }
    addNotHiredRoomsToLayout();
}

public void addHiredRoomToLayout(Room room) {
    textView = new TextView(this);
    textView.setText(room.getParameters());
    linearLayout.addView(textView);
}

public void addNotHiredRoomsToLayout() {
    textView2 = new TextView(this);
    for (String name : Constants.existingRoomNames) {
        boolean contains = false;
        for (Room room : mCalendarModel.mList.getRoomList()) {
            if (room.getName().equals(name)) {
                contains = true;
            }
        }
        if (!contains) {
            textView2.setText(name + ": Free");
            linearLayout.addView(textView2);
        }
    }
}

Here's the XML:

<LinearLayout
    android:orientation="vertical"
    android:layout_width="313dp"
    android:layout_height="150dp"
    android:id="@+id/linear1"
    android:layout_gravity="center"></LinearLayout>

which is inside the parent LinearLayout.

I get exception like this:

`java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.`

on the last line:

linearLayout.addView(textView2);

What's the problem there?

Tarun Gupta · Accepted Answer · 2016-07-22 12:44:48Z

2

You are adding the same view to the layout again. Change your function to

public void addNotHiredRoomsToLayout() {

for (String name : Constants.existingRoomNames) {
    textView2 = new TextView(this);
    boolean contains = false;
    for (Room room : mCalendarModel.mList.getRoomList()) {
        if (room.getName().equals(name)) {
            contains = true;
        }
    }
    if (!contains) {
        textView2.setText(name + ": Free");
        linearLayout.addView(textView2);
    }
}
}

answered Jul 22, 2016 at 12:44

Tarun Gupta

3072 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jas · Accepted Answer · 2016-07-22 12:43:02Z

1

Move

linearLayout = (LinearLayout) findViewById(R.id.linear1);
linearLayout.removeAllViews();

inside

public void addHiredRoomToLayout(Room room) {
    textView = new TextView(this);
    textView.setText(room.getParameters());
    linearLayout.addView(textView);
}

answered Jul 22, 2016 at 12:43

Jas

3,2222 gold badges19 silver badges47 bronze badges

Comments

Sergei Kozelko · Accepted Answer · 2016-07-22 12:45:43Z

1

The problem is that you use the same TextView every time. If you want to use multiple TextViews then change your loop to

for (String name : Constants.existingRoomNames) {
    textView2 = new TextView(this); //create a new TextView that wasn't added to layout yet

    boolean contains = false;
    for (Room room : mCalendarModel.mList.getRoomList()) {
        if (room.getName().equals(name)) {
            contains = true;
        }
    }
    if (!contains) {
        textView2.setText(name + ": Free");
        linearLayout.addView(textView2);
    }
}

answered Jul 22, 2016 at 12:45

Sergei Kozelko

8536 silver badges20 bronze badges

Comments

Dharvik shah · Accepted Answer · 2016-07-22 12:57:52Z

0

Please try this -> Make one xml layout file named "text_view":

<TextView xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_height="wrap_content"
    android:layout_width="wrap_content"/>

then line to solve this problem :

textView2 = (TextView) getLayoutInflater().inflate(R.layout.text_view, null);

answered Jul 22, 2016 at 12:57

Dharvik shah

1,98914 silver badges27 bronze badges

Collectives™ on Stack Overflow

Adding multiple TextViews into LinearLayout dynamically

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related