Add TextViews programmatically

Question

I have an empty LinearLayout, and I need to add a dynamic number of TextViews to it. However when I use the code below, only the first TextView is shown:

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    String[] listofnumbers = new String[1000];
    for ( int i = 0 ; i < 1000 ; ++i )  {
        listofnumbers[i] = "null";
    }

    Context context = getBaseContext();

    String text = null;

    Uri uri = Uri.parse("content://sms");
    Cursor cursor = context.getContentResolver().query(uri, null, null, null, null);

    String[] columnNames = cursor.getColumnNames();
    LinearLayout lv = new LinearLayout(context);
    LinearLayout.LayoutParams textViewParams = new LinearLayout.LayoutParams(LayoutParams.FILL_PARENT, dip(48));

    boolean v = true;
    while (cursor.moveToNext()) 
    {
        String numberString = (cursor.getString( cursor.getColumnIndexOrThrow("address") ) ).replace(" ", "");

        int i = 0;
        boolean numberNotPresent = true;
        for (  ; listofnumbers[i] != "null" ; ++i ) {
            if ( numberString.equals(listofnumbers[i])  )   {
                numberNotPresent = false;
            }
        }
        if ( numberNotPresent == true ) {
            text = (CharSequence) "From: " + cursor.getString(cursor.getColumnIndexOrThrow("address")) + ": " + cursor.getString(cursor.getColumnIndexOrThrow("body"));
            listofnumbers[i] = numberString;
            TextView tv = new TextView(this);
            tv.setText(text);
            tv.setLayoutParams(textViewParams);
            lv.addView( tv );
        }
    }
    setContentView(lv);
}

Where have I gone wrong?

are you sure the condition if ( numberNotPresent == true ) is being met? maybe add some logging and see if you're actually getting into that code and trying to add another TextView — dldnh
– dldnh, Commented Mar 18, 2012 at 16:28
Remove the condition for once and check again, if you get the TextView this time, means there's a problem in your condition. And I'd go with @dldnh about logging too. — 0xC0DED00D
– 0xC0DED00D, Commented Mar 18, 2012 at 16:45
The conditions were being met. I had forgotten to set the LinearLayout orientation, as @bytebiscuit had suggested — frazer
– frazer, Commented Mar 19, 2012 at 17:19

bytebiscuit · Accepted Answer · 2012-03-18 16:45:38Z

3

try to change these two lines:

LinearLayout lv = new LinearLayout(context);
    LinearLayout.LayoutParams textViewParams = new LinearLayout.LayoutParams(LayoutParams.FILL_PARENT, dip(48));

with these:

LinearLayout lv = new LinearLayout(context);
        lv.setOrientation(LinearLayout.VERTICAL);
        LinearLayout.LayoutParams textViewParams = new LinearLayout.LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT);

basically you need to set the orientation for the lv LinearLayout to vertical as the default one is horizontal.

answered Mar 18, 2012 at 16:45

bytebiscuit

3,49610 gold badges37 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ilya Demidov · Accepted Answer · 2012-03-18 18:25:03Z

1

I am not sure, but may be for each textView you set fill_parent param? The 1st textView shows on all your layout.

edited Mar 18, 2012 at 18:25

answered Mar 18, 2012 at 16:39

Ilya Demidov

3,3052 gold badges28 silver badges39 bronze badges

Collectives™ on Stack Overflow

Add TextViews programmatically

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related