issue with the simple if condition in javascript with string

Question

So something very strange,below are the alert values:

consumerSupportEditableRole = true
superAdminRole = false
combinedRole = false

However the strange thing is that the the alert on the combinedRole give me consumerSupport/ConsumerContact/GetEmailLog. So it is for some ungodly reason going in the if block. I would expect it to go to the else block and the alert should spit Implementation/Organization/GetEmailLog

var consumerSupportEditableRole = '@(Roles.IsUserInRole("Consumer Support Editable") ? "true" : "false")';
var superAdminRole = '@(Roles.IsUserInRole("Super Admin") ? "false" : "true")';
var combinedRole = consumerSupportEditableRole && superAdminRole
alert("consumerSupportEditableRole: " + consumerSupportEditableRole);
alert("superAdminRole: " + superAdminRole);
alert("superAdminRole && consumerSupportEditableRole: " + combinedRole);
if (combinedRole)
{
    var url = '@Url.Action("GetEmailLog", "ConsumerContact", new { Area = "ConsumerSupport" })';
}
else
{
    var url = '@Url.Action("GetEmailLog", "Organization", new { Area = "Implementation" })';
}

Don't use strings to hold boolean values, and you will be sweet. — alex
– alex, Commented Aug 10, 2016 at 14:20

Maxx · Accepted Answer · 2016-08-10 14:19:50Z

4

Remove quotes, you get not booleans in JS, but strings

var consumerSupportEditableRole = @(Roles.IsUserInRole("Consumer Support Editable") ? "true" : "false");
var superAdminRole = @(Roles.IsUserInRole("Super Admin") ? "false" : "true");
var combinedRole = consumerSupportEditableRole && superAdminRole
alert("consumerSupportEditableRole: " + consumerSupportEditableRole);
alert("superAdminRole: " + superAdminRole);
alert("superAdminRole && consumerSupportEditableRole: " + combinedRole);
if (combinedRole)
{
    var url = '@Url.Action("GetEmailLog", "ConsumerContact", new { Area = "ConsumerSupport" })';
}
else
{
    var url = '@Url.Action("GetEmailLog", "Organization", new { Area = "Implementation" })';
}

answered Aug 10, 2016 at 14:19

Maxx

1,75810 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Rich Linnell Over a year ago

'true' is not the same as true

adeneo Over a year ago

@rpadovani - he did, as that is serverside code, no longer outputted inside quotes, hence removed.

Maxx Over a year ago

@rpadovani you don't need to. Seems like it's C# generates JS code, in C# "true" and "false" is string i guess, but qoutes will not prints, so in JS it becomes boolean.

James Thorpe · Accepted Answer · 2016-08-10 14:20:05Z

3

You're setting consumerSupportEditableRole and superAdminRole to strings, not booleans. So combinedRole is actually:

var combinedRole = "true" && "false";

which makes it "false", which is truthy.

answered Aug 10, 2016 at 14:20

James Thorpe

32.3k6 gold badges76 silver badges95 bronze badges

Collectives™ on Stack Overflow

issue with the simple if condition in javascript with string

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related