Checking a select-all checkbox in WPF doesn't change other checkboxes in Listbox

Question

I implemented a ListBox using this and this. I bind my actual list of 29 objects to it and it works well. In XAML:

<ListBox Name="WBauNrList" ItemsSource="{Binding}"  Grid.Row="7" Grid.Column="2" ScrollViewer.VerticalScrollBarVisibility="Visible" ScrollViewer.CanContentScroll="True" Height="100" >
    <ListBox.ItemTemplate>
        <HierarchicalDataTemplate>
            <CheckBox Content="{Binding Baunr}" IsChecked="{Binding IsChecked,Mode=TwoWay}"/>
        </HierarchicalDataTemplate>
    </ListBox.ItemTemplate>
</ListBox>

In code:

datenpunktList = new ObservableCollection<Datenpunkt>();
foreach (var d in WerkstattList.DistinctBy(p => p.lokNr))
{
    var newd = new Datenpunkt() { Baunr = d.lokNr };
    datenpunktList.Add(newd);
}

WBauNrList.ItemsSource = datenpunktList;

But the problem:

I want to have a select-all CheckBoxes to able the user to select and deselect all items. It works strangely!

After checking the selectAll CheckBox, all items will be checked that is not in the scope of the scrollbar (the list is scrolled), then I should scroll down and up to see that all items are checked.

XAML:

<CheckBox Name="selectAll" Click="selectAll_Click" >Secelct all</CheckBox>

Code:

private void selectAll_Click(object sender, RoutedEventArgs e)
{
    foreach (Datenpunkt item in WBauNrList.Items)
    {
        item.IsChecked = true ;
    }
}

I don't have any idea what to do.

Thanks in advance, Mo

Have you implemented the INotifyPropertyChanged interface for the IsCheckedproperty of your Datenpunkt class? — Mighty Badaboom
– Mighty Badaboom, Commented Jul 11, 2017 at 13:09
@MightyBadaboom no. should it look like this? public static readonly DependencyProperty isCheckedProperty = DependencyProperty.Register("IsChecked", typeof(bool), typeof(MainWindow), new UIPropertyMetadata(null)); — Mo MahdiM
– Mo MahdiM, Commented Jul 11, 2017 at 13:12
If you are binding a property to your xaml and you want your ui to be updated when the property is changed via code you have to implement the INotifyPropertyChanged interface. No, that would be a dependency property. — Mighty Badaboom
– Mighty Badaboom, Commented Jul 11, 2017 at 13:13

Mighty Badaboom · Accepted Answer · 2017-07-11 13:17:23Z

3

Your property IsChecked implementation could look like this.

public class Datenpunkt : INotifyPropertyChanged
{
    public event PropertyChangedEventHandler PropertyChanged;

    public void Notify(string propertyName)
    {
        if (PropertyChanged != null)
        {
            PropertyChanged(this, new PropertyChangedEventArgs(propertyName));
        }
    }

    private bool _isChecked;
    public bool IsChecked
    {
        get { return _isChecked; }
        set
        {
            _isChecked = value;
            Notify("IsChecked");
        }
    }
}

Have a look at the MSDN INotifyPropertyChanged page for more information.

answered Jul 11, 2017 at 13:17

Mighty Badaboom

6,1735 gold badges37 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Checking a select-all checkbox in WPF doesn't change other checkboxes in Listbox

But the problem:

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

But the problem:

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related