Checkbox in wpf listview header not checking all items

Question

I have a listview in my WPF application and the first column is a Checkbox. This checkbox is bound to the IsSelected property of my model and the event propogation happens correctly.

I also have a Checkbox in the same column's header and want to implement a 'Select All' feature where it checks all the listview items.

I can attach to the process and see that the data is changing when I go and programatically change the data in the model, but it does not reflect in the UI. I have INotifyPropertyChanged implemented as well.

Can someone explain what I am doing wrong here..

The relevant code portions are mentioned below..

Xml:

<ListView Height="470" ItemsSource="{Binding Path=Songs,UpdateSourceTrigger=PropertyChanged,Mode=TwoWay}" IsSynchronizedWithCurrentItem="True"
                      x:Name="yourSongListView" GridViewColumnHeader.Click="GridViewColumnHeaderClickedHandler"

                      ItemContainerStyle="{StaticResource itemStyle}" AlternationCount="2">
                <ListView.View>
                    <GridView ColumnHeaderContainerStyle="{StaticResource CustomHeaderStyle}" >
                        <GridView.Columns>
                            <GridViewColumn HeaderTemplate="{StaticResource checkboxHeaderTemplate}" 
                                            CellTemplate="{StaticResource CheckBoxCell}" Width="30">

                            </GridViewColumn>
                            <GridViewColumn CellTemplate="{StaticResource TitleTemplate}" Width="450">
                                <GridViewColumnHeader Content="TITLE" Tag="Title" />
                            </GridViewColumn>
                        </GridView.Columns>
                    </GridView>
                </ListView.View>
            </ListView>


<DataTemplate x:Key="checkboxHeaderTemplate">
            <CheckBox Checked="CheckBox_Checked">
                <CheckBox.Template>
                    <ControlTemplate TargetType="CheckBox">
                        <Image Name="TickImage" Source="Images\track-list-select.png" Width="18" Height="18" />
                        <ControlTemplate.Triggers>
                            <Trigger Property="IsChecked" Value="True">
                                <Setter TargetName="TickImage" Property="Source" Value="Images\track-list-select-active.png" />
                            </Trigger>
                        </ControlTemplate.Triggers>
                    </ControlTemplate>
                </CheckBox.Template>
            </CheckBox>
        </DataTemplate>


 <DataTemplate x:Key="CheckBoxCell">
            <CheckBox  IsChecked="{Binding Path=IsSelected, Mode=TwoWay}" >
                <CheckBox.Template>
                    <ControlTemplate TargetType="CheckBox">
                        <Image Name="TickImage" Source="Images\track-list-select.png" Width="18" Height="18" />
                        <ControlTemplate.Triggers>
                            <Trigger Property="IsChecked" Value="True">
                                <Setter TargetName="TickImage" Property="Source" Value="Images\track-list-select-active.png" />
                             </Trigger>
                        </ControlTemplate.Triggers>
                    </ControlTemplate>
                </CheckBox.Template>
            </CheckBox>
        </DataTemplate>

Code :

 private void CheckBox_Checked(object sender, RoutedEventArgs e)
        {
            CheckBox c = sender as CheckBox;
            if (c.IsChecked.HasValue)
            {
                Model.ToggleAllSelection(c.IsChecked.Value);
            }
            else
            {
                Model.ToggleAllSelection(false);
            }
        }


 public void ToggleAllSelection(bool newState)
            {
                foreach (var item in Songs)
                {
                    item.IsSelected = newState;
                    InvokePropertyChanged("IsSelected");
                }

                InvokePropertyChanged("Songs");
            }

Songs is a ObservableCollection

dev hedgehog · Accepted Answer · 2013-09-23 15:32:28Z

1

If you wish to fire property changed on a property you will need to fire the event in the class which owns the property.

In your example you are not firing the event inside the class Song.

This is how you should fire the event properly:

class Song
{
  prop IsSelected
  {
    get { return this.selected; }
    set { this.selected = value; PropertyChanged("IsSelected"); }
  }
}

OLD: Could you show us what is InvokePropertyChanged doing?

Where does the method ToggleAllSelection come from?

Sorry I apply this as answer. I cannot post comments yet.

edited Sep 23, 2013 at 15:32

answered Sep 22, 2013 at 15:10

dev hedgehog

8,8414 gold badges33 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Sharath Over a year ago

InvokePropertyChanged("Songs"); is just the implementation of INotifyPropertyChanged interface.. and ToggleAllSelection() changes the IsSelected property of my model..

dev hedgehog Over a year ago

What is the name of the class containing InvokePropertyChanged? What is the name of the class containing ToggleAllSelection? Are those two different classes?

Sharath Over a year ago

No they are the same class.. the class implements INotifyPropertyChanged

dev hedgehog Over a year ago

I edited my answer. You are not firing the propertychanged event properly.

Sharath Over a year ago

This worked.. I understand now.. the objects inside the collection are not dependency objects and so do not fire off change notification events.. Thanks..

Collectives™ on Stack Overflow

Checkbox in wpf listview header not checking all items

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related