PHP while loop, table row

Question

I'm trying to loop through a database and output data into a div, if there are 3 divs horizontally across it will the start a new tr until it reaches another 3 etc. It is currently outputted like :

[] [] []
[]
[] []

Currently I have it working when it reaches 3 it starts a new row, but I don't know how I can only echo a new tr once? As it creates a new table row each time.

echo '<table><tr>';  

while ($result) 
{
    $i ++;
    if ($i&3)
    {
      echo '<td>
         <div>Row Data</div>
       </td>'; 
    }

    else
    {       
      echo '<tr>
        <td>
          <div>Row Data</div>
        </td></tr>';
   }
}  
echo '</tr></table>';

The $result variable is the recordset from my SQL query, everything works fine I just don't know how to only create a new table row once?

where do you close the first tr that you open? The one near the table declaration. — vladv
– vladv, Commented Jan 2, 2011 at 16:35

TimeParadox · Accepted Answer · 2017-01-15 23:01:07Z

2

you need to reset your $i variable to 1 when you hit 3...

$i = 0;
echo '<table><tr>';  

while ($result) 
{

    if ($i<=2)
    {
      echo '<td>
         <div>Row Data</div>
       </td>'; 
    }

    else
    {       
      echo '</tr><tr>';
      echo '<td><div>Row Data</div></td>'; 
      $i = 0;
   }
    $i ++;

}  
echo '</tr></table>';

Or something like this...

edited Jan 15, 2017 at 23:01

TimeParadox

3181 gold badge3 silver badges19 bronze badges

answered Jan 2, 2011 at 16:50

webdad3

9,15031 gold badges130 silver badges229 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dharman · Accepted Answer · 2020-07-07 08:45:33Z

2

echo '<table><tr>';
$i = 0;
while ($result) {
   if ($i > 2) {
      echo '</tr><tr>';
      $i = 0;
   }
   echo '<td></td>';
   $i++;
}
echo '</tr></table>';

edited Jul 7, 2020 at 8:45

Dharman♦

33.9k27 gold badges105 silver badges157 bronze badges

answered Jan 2, 2011 at 16:50

dqhendricks

19.2k11 gold badges54 silver badges88 bronze badges

Comments

vladv · Accepted Answer · 2011-01-02 16:52:54Z

1

I think you have a slightly slip of logic in your code. You want to break the line when 3 <td> have been added. currently you add a <td> in any case. Your counting is not working anymore.

Also I don't think bitwise operation is what you want. If you want 3 td's all the time, you will not accomplish that with &3. for example 3$3 is true, but 6&3 is not true. 7&3 is true. 11&3 is true. then 15&3 is true. You can either reset $i or you can use the % operator.

answered Jan 2, 2011 at 16:52

vladv

6386 silver badges12 bronze badges

Comments

Zeus · Accepted Answer · 2011-01-02 17:02:54Z

0

Or with modulo:


    if ($i % 3 == 0) {
      echo '</tr><tr>';
    }

so you wouldnt have to reset the $i.

answered Jan 2, 2011 at 17:02

Zeus

8745 silver badges18 bronze badges

Comments

Lightness Races in Orbit · Accepted Answer · 2011-01-02 23:16:26Z

0

else
{       
  echo '<tr>
    <td>
      <div>Row Data</div>
    </td></tr>';
}

should read:

else
{       
  echo '</tr><tr>
    <td>
      <div>Row Data</div>
    </td>';
}

answered Jan 2, 2011 at 23:16

Lightness Races in Orbit

387k77 gold badges670 silver badges1.1k bronze badges

Collectives™ on Stack Overflow

PHP while loop, table row

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related