PHP While HTML Table

Question

I am trying to get my code to display in an HTML table using the while loop. However, I can't get my table to display. Is there something wrong with the way I am trying to echo the table out?

 <?php


 #-----call includes-----# include('E:/includes/database.php'); 
 include('E:/includes/sendmail.php');

 ini_set('error_reporting', E_ALL ^ E_NOTICE); 
 ini_set('display_errors','on');


 $do = $_REQUEST['do']; 


$queryOrders = "select t2.SlpName As 'Seller', t1.SWW As 'Vendor', t0.DocDate As 'Date',t0.DocTotal As 'Total'
                from twh.dbo.OINV t0
                  inner join twh.dbo.inv1 t1  on t0.DocEntry = t1.DocEntry

         inner join twh.dbo.OSLP t2 on t1.SlpCode = t2.SlpCode
                where t0.DocDate > DATEADD (month, -2, getdate())
                  order by t0.DocTotal desc";

$resultItemData = sqlsrv_query($con, $queryOrders);


    echo "<table border=\"1\" align=\"center\">";
    echo "<tr><th>Seller</th>";
    echo "<th>Vendor</th>";
    echo "<th>Date</th>";
    echo "<th>Total</th></tr>"
    while($rowItemData = sqlsrv_fetch_array($resultItemData)){
        echo "<tr><td>";
        echo "$resultItemData";
        echo "</td></tr>";
    endwhile;

    }
    echo"</table>";

See answers they pinpoint your syntax issue.. Also would suggest, not doing echo for every line --- that is not needed. Or use a heredoc. — gview
– gview, Commented Aug 24, 2017 at 14:53

AT-2017 · Accepted Answer · 2017-08-24 14:51:48Z

1

Modified a little bit. Check this:

while($rowItemData = sqlsrv_fetch_array($resultItemData)) :
    echo "<tr><td>";
    echo $rowItemData[ColumnValue]; //In your code, didn't access the column value earlier 
    echo "</td></tr>";
endwhile;

answered Aug 24, 2017 at 14:51

AT-2017

3,1494 gold badges28 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

random_user_name · Accepted Answer · 2017-08-24 15:05:20Z

1

There's a combination of problems at play:

First, you open the while with {, but close with endwhile; - while technically not a problem, it's not consistent - if you open with {, it's best practice to close with }.
Second, you're attempting to echo an entire array, which won't work properly.
Third, no need to put the value inside of quotes: echo "$resultItemData"; could simply be echo $resultItemData.
Fourth, you're attempting to echo $resultItemData, which is a resource, not the row data. You want to echo $rowItemData values.
And finally, you'll likely want the results in an associative array, rather than a numerically-indexed array, so you might consider using sqlsrv_fetch_array( $resultItemData, SQLSRV_FETCH_ASSOC).

Below is your code, revised to work, and follow a bit better practices:

// columns: 'Seller',Vendor, 'Date', 'Total'
while( $rowItemData = sqlsrv_fetch_array( $resultItemData, SQLSRV_FETCH_ASSOC ) ) {
    echo "<tr><td>";
    echo "<td>$rowItemData['Seller']</td>";
    echo "<td>$rowItemData['Vendor']</td>";
    echo "<td>$rowItemData['Date']</td>";
    echo "<td>$rowItemData['Total']</td>";
    echo "</tr>";
}

edited Aug 24, 2017 at 15:05

answered Aug 24, 2017 at 15:00

random_user_name

26.3k7 gold badges81 silver badges119 bronze badges

1 Comment

AT-2017 Over a year ago

Good explanation @cale_b.

Nana Partykar · Accepted Answer · 2017-08-24 14:58:56Z

0

You should specify the indexes of the array $rowitemdata.

For example:

echo"<tr><td>".$rowitemdata['Vendor']."

edited Aug 24, 2017 at 14:58

Nana Partykar

10.5k10 gold badges50 silver badges79 bronze badges

answered Aug 24, 2017 at 14:58

Diego Albano

1

Comments

Krish · Accepted Answer · 2017-08-24 15:00:51Z

0

I haven't gone through your full code, but I can see wrong syntax for while

while($rowItemData = sqlsrv_fetch_array($resultItemData)){
    echo "<tr>";
    echo "<td>".$resultItemData['Seller']."</td>";
    echo "<td>".$resultItemData['Vendor']."</td>";
    echo "<td>".$resultItemData['Date']."</td>";
    echo "<td>".$resultItemData['Total']."</td>";
    echo "</tr>";
}

or

while($rowItemData = sqlsrv_fetch_array($resultItemData)) :
    echo "<tr>";
    echo "<td>".$resultItemData['Seller']."</td>";
    echo "<td>".$resultItemData['Vendor']."</td>";
    echo "<td>".$resultItemData['Date']."</td>";
    echo "<td>".$resultItemData['Total']."</td>";
    echo "</tr>";
endwhile;

Update: still you can optimize the code, I just gave sample working

edited Aug 24, 2017 at 15:00

answered Aug 24, 2017 at 14:49

Krish

3872 silver badges13 bronze badges

2 Comments

gview Over a year ago

Yes but you did not point out the issue with trying to echo out a query handle.

Nana Partykar Over a year ago

echo $resultItemData; is suspicious to me. Which results ..Catchable fatal error: Object of class sqlsrv_result could not be converted to string

gview · Accepted Answer · 2017-08-24 15:17:06Z

Let's assume your query actually produces a result, because you don't check that it does:

$resultItemData = sqlsrv_query($con, $queryOrders);

$header = <<<HEREDOC
<table border="1" align="center">
<tr>
  <th>Seller</th>
  <th>Vendor</th>
  <th>Date</th>
  <th>Total</th>
</tr>
HEREDOC;

echo $header;

while($rowItemData = sqlsrv_fetch_array($resultItemData)) {
    echo "<tr>
            <td>{$rowItemData['Seller']}</td>
            <td>{$rowItemData['Vendor']}</td>
            <td>{$rowItemData['Date']}</td>
            <td>{$rowItemData['Total']}</td>
          </tr>";
}
echo '</table>';

To actually check that the query works, you might want to do this instead. This is just to debug/illustrate error checking for the query execution. You wouldn't want to output an error to the screen, but rather log it. You probably want to just output the table header/footer and skip the while/loop entirely.

$resultItemData = sqlsrv_query($con, $queryOrders);
if (resultItemData === false) {
    die(print_r(sqlsrv_errors(), true));
}

Collectives™ on Stack Overflow

PHP While HTML Table

5 Answers 5

Comments

1 Comment

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related