Using LINQ instead of using for-each loop

Question

I have the following code. How to convert this into a LINQ? Any one please help me.

In the below code 'powd' contains the db values and purchaseOrderUpdateRequest contains data submitted by user.

bool hasUpdate;

foreach (var item in purchaseOrderUpdateRequest.Lines)
{
    var line = powd.PurchaseOrderLines.Single(p => p.ItemNumber ==  item.ItemNumber);
    decimal quantityToReceive = item.QuantityReceived - line.QuantityReceivedToDate;

    if (quantityToReceive > 0)
    {
        hasUpdate =true;
        break;
    }
}

Thanks.

Jon Skeet · Accepted Answer · 2011-05-14 07:42:06Z

13

So all you're trying to work out is whether any item has an update? That's just:

var hasUpdate = purchaseOrder.UpdateRequest.Lines.Any(item =>
     item.QuantityReceived < powd.PuchaseOrderLines
                                 .Single(p => p.ItemNumber == item.ItemNumber)
                                 .QuantityReceivedToDate)

I've changed the comparison to just use a direct < rather than a subtraction and a comparison with 0, but this should be okay.

answered May 14, 2011 at 7:42

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

aKzenT · Accepted Answer · 2011-05-15 21:46:28Z

0

Untested, but this should do the same and might be easier to read:

   var quantities = (from item in purchaseOrderUpdateRequest.Lines
                     from item2 in powd.PurchaseOrderLines
                     where item.ItemNumber == item2.ItemNumber
                     select item.QuantityReceived - item2.QuantityReceivedToDate);
   hasUpdate = quantities.Any(quantityToReceive => (decimal) quantityToReceive > 0);

answered May 15, 2011 at 21:46

aKzenT

7,9153 gold badges38 silver badges66 bronze badges

Collectives™ on Stack Overflow

Using LINQ instead of using for-each loop

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related