Using a LINQ query instead of a foreach loop

Question

I want to convert this this piece of code to a LINQ query as LINQ is much quicker than a foreach. I dont know how to go about doing it, can do basically simple LINQ queries.

What i am trying to do is get a specific field in the dictionary.

Dictionary<string, object> fieldLayout = null;
foreach (Dictionary<string, object> dic in pageLayout)
{
    if (dic[ "FIELD" ].ToString() == "123")
    {
        fieldLayout = dic;
        break;
    }
}

Why do you think that Linq is quicker than foreach? Do you need to optimize this code? — Wouter de Kort
– Wouter de Kort ♦, Commented Jul 30, 2012 at 11:45
Why do you keep object, not string? Calling ToString() is not the best choice! — abatishchev
– abatishchev, Commented Jul 30, 2012 at 11:50

Dave New · Accepted Answer · 2012-07-30 11:58:30Z

3

Firstly, LINQ is not faster than a foreach loop.

Here is the implementation:

Dictionary<string, object> fieldLayout = pageLayout.Where(x => x["FIELD"].ToString() == "123").FirstOrDefault();

Or even better:

Dictionary<string, object> fieldLayout = pageLayout.FirstOrDefault(x => x["FIELD"].ToString() == "123");

edited Jul 30, 2012 at 11:58

answered Jul 30, 2012 at 11:45

Dave New

40.3k62 gold badges235 silver badges412 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

abatishchev Over a year ago

I'd recommend to leave only the 2nd.

Konrad Morawski · Accepted Answer · 2012-07-30 11:44:23Z

3

fieldLayout = pageLayout.FirstOrDefault(dic => dic["FIELD"].ToString() == "213");

answered Jul 30, 2012 at 11:44

Konrad Morawski

8,4047 gold badges57 silver badges92 bronze badges

1 Comment

Zarat Over a year ago

Should be dic["FIELD"].ToString() like in the original code because the dictionary has values of type object. Otherwise you'd do a by-reference comparison which is not useful.

Anton Gogolev · Accepted Answer · 2012-07-30 11:45:11Z

2

LINQ is hardly faster than foreach, but that's outside the scope here.

var fieldLayout = pageLayout.FirstOrDefault(pl => pl["FIELD"].ToString() == "123");

answered Jul 30, 2012 at 11:45

Anton Gogolev

116k39 gold badges204 silver badges293 bronze badges

Collectives™ on Stack Overflow

Using a LINQ query instead of a foreach loop

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related