Creating file with Bash scripting for loop and if test

Question

Problem Statement Find files using bash script In this section, you are going to write a script named findJane.sh within the scripts directory.

This script should catch all "jane" lines and store them in another text file called oldFiles.txt. You will complete the script using the command we practiced in earlier sections. Don't worry, we'll guide you throughout the whole process.

Navigate to /scripts directory and create a new file named findJane.sh.

Mycode


#!/bin/bash


>oldFiles.txt

files=$(grep  " jane " ../data/list.txt | cut -d ' ' -f 3)

for i in $files:do

  do if test -e ~/data/"$i"; then 
     echo "$i" >> OldFiles.txt; 
  else 
     echo "File doesn't exist"; fi
done

output now file does not exist file does not exist file does not exist it should not print nothing and cat oldFiles.txt should return all those files with name 'jane

Where i am coding wrong

Guide Create the text file oldFiles.txt and make sure it's empty. This oldFiles.txt file should save files with username "jane".

Now, search for all lines that contain the name "jane" and save the file names into a variable. Let's call this variable files, we will refer to it with that name later in the lab.

Since none of the files present in the file list.txt are available in the file system, check if file names present in files variable are actually present in the file system. To do this, we'll use the test command that we practiced in the previous section.

Now, iterate over the files variable and add a test expression within the loop. If the item within the files variable passes the test, add/append it to the file oldFiles.txt.

For starters, you need to enclose the command that sets files, so files=$(...). Then, use the-l or --files-with-matches option to just get filenames. Even with that, if a filename has a space in it, the for loop will split the filename. (Person who put that space in the filename should be charged with conduct unbecoming of a human being.) — Jack
– Jack, Commented Jun 1, 2020 at 14:40
@Jack just a newbee please elaborate,your sarcasm is quite strong :).Looking for a clear answer. — rakesh.data
– rakesh.data, Commented Jun 1, 2020 at 15:04
you're on the right track. Fix the syntax errors uncomvered at shellcheck.net . Be sure to use #!/bin/bash as the first line when you post there (you're missing a # char). If fixing the syntax errors doesn't solve your problem, then edit your Q with updated code so people aren't wasting time commenting on easy fixes. Include exact text of any error messages generated. Good luck. — shellter
– shellter, Commented Jun 1, 2020 at 15:36
As I said, you don't need all that | cut ... stuff. Just use the -l option on grep. — Jack
– Jack, Commented Jun 1, 2020 at 17:21

Satkal · Accepted Answer · 2020-06-13 08:18:28Z

5

I have the same problem, just don't call the files by $in grep

#!/bin/bash

files= grep ' jane ' ../data/list.txt | cut -d ' ' -f 3

for file in files; do

   if  test -e ~/data/$file; then
     echo  $file >> oldFiles.txt;
   else
     echo "File dosen't exsist"; fi
done

And make the new fie .oldFiles.txt in the command line

like user@linux: ~/program$ ./findJane.sh > oldFiles.txt

The code shall work

answered Jun 13, 2020 at 8:18

Satkal

532 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

fcdt · Accepted Answer · 2020-09-14 12:49:40Z

3

If you're trying to do a Qwicklabs assignment, try this

#!/bin/bash

> oldFiles.txt

files=$(grep " jane " /home/<Student-id>/data/list.txt | cut -d ' ' -f 3)

for i in $files;do

if test -e ~/$i;then

echo $i>>oldFiles.txt;

else echo "not working"; fi

done

edited Sep 14, 2020 at 12:49

fcdt

2,5215 gold badges17 silver badges27 bronze badges

answered Sep 14, 2020 at 6:33

anonymous

311 bronze badge

1 Comment

WSC Over a year ago

Your question is not clear. What are you trying to achieve? What errors/problems are you encountering? Please read this for help on asking a good question: How to Ask

CIPHER · Accepted Answer · 2020-06-10 15:49:04Z

2

#!/bin/bash

>oldFiles.txt

files=$(grep " jane " ../data/list.txt | cut -d ' ' -f 3)

for i in $files; do

  if test -e ~/$i; then
    echo $i >> OldFiles.txt; 
  else 
    echo "File doesn't exist"; fi
done

edited Jun 10, 2020 at 15:49

answered Jun 10, 2020 at 11:37

CIPHER

771 gold badge1 silver badge6 bronze badges

Comments

alecxs · Accepted Answer · 2020-06-01 22:01:53Z

0

you have just some typos. this is "working" code for your example

#!/bin/bash

>oldFiles.txt

files=$(grep " jane " ../data/list.txt | cut -d ' ' -f 3)

for i in $files; do

  if test -e ~/data/"$i"; then
    echo "$i" >> OldFiles.txt; 
  else 
    echo "File doesn't exist"; fi
done

however, this works only if list.txt doesn't contain any spaces except as delimiters between (at least) three columns

it won't work for Jane because it doesn't match jane
it won't work when there are more spaces like jane example.doc
it won't work for file names containing spaces like best movies.txt

it makes less sense to show how to do it right because the concept of list.txt is bad choice

answered Jun 1, 2020 at 22:01

alecxs

75110 silver badges18 bronze badges

Comments

tpschmidt · Accepted Answer · 2020-07-18 14:51:57Z

0

#!/bin/bash

>oldFiles.txt

files=$(grep " jane " ../data/list.txt | cut -d ' ' -f 3)

for file in $files; do 
  if [ -e $HOME$file ] ; then 
    echo $HOME$file >> oldFiles.txt; 
  fi 
done

edited Jul 18, 2020 at 14:51

tpschmidt

2,7472 gold badges24 silver badges34 bronze badges

answered Jul 18, 2020 at 13:15

ketan910

11

Comments

tripleee · Accepted Answer · 2020-07-18 15:19:36Z

0

#!/bin/bash
> oldFiles.txt
files=$(grep ' jane ' ../data/list.txt | cut -d ' ' -f 3)
#echo $files
for file in $files; do
        if  test -e ~/$file; then
                echo "File path added !!"
                echo  $file >> oldFiles.txt;
   fi
done

edited Jul 18, 2020 at 15:19

tripleee

192k37 gold badges318 silver badges367 bronze badges

answered Jul 10, 2020 at 17:42

Pradnyesh Doshi

1

1 Comment

Farbod Ahmadian Over a year ago

Please correct your markdown and give some details.

NewbieDeveloper · Accepted Answer · 2021-06-19 19:49:39Z

0

You need to check the path and then append it to the oldFile

#1/bin/bash
>oldFiles.txt
files=$(grep "jane " ../data/list.txt | cut -d' ' -f3)
for f in $files; do
 if [ -e $HOME$f ];then
    echo $HOME$f >> oldFiles.txt;
 fi
 done

answered Jun 19, 2021 at 19:49

NewbieDeveloper

11 bronze badge

Comments

Jesús Martín · Accepted Answer · 2022-08-21 08:30:04Z

0

I made a few fixes to your code and now works 😉

#!/bin/bash

> oldFiles.txt

files=$(grep " jane " ../data/list.txt | cut -d " " -f 3)
for file in $files; do
if test -e ~/$file; then echo $file  >> oldFiles.txt; else echo "File doesn't exist"; fi done

answered Aug 21, 2022 at 8:30

Jesús Martín

235 bronze badges

Collectives™ on Stack Overflow

Creating file with Bash scripting for loop and if test

8 Answers 8

Comments

1 Comment

Comments

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

Comments

1 Comment

Comments

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related