OOP in PHP - object array iteration

Question

I am trying to iterate through array of objects in PHP, but I can't figure it out. This is my code:

    require_once("databaseConnect.php");
require_once("class/Ticket.php");

function showAll(){
    $sql = "SELECT * FROM Ticket WHERE Status='1'";
    $p = mysql_query($sql);
    while ($row = mysql_fetch_object($p)){ 
        $t = new Ticket($row->IDTicket, $row->IDUser, $row->TotalOdd, $row->PlacedBet, $row->PossibleWin, $row->Status, $row->Won, $row->Time);
        $nizTiketa[] = $t;
    }
    return $nizTiketa;
}

$niz = showAll();

for ($i; $i<count($niz); $i++){
    echo $niz[$i]->getIDTicket()."<br/>";
}

and this is class Ticket:

class Ticket {
private $IDTicket;
private $IDUser;
private $TotalOdd;
private $PlacedBet;
private $PossibleWin;
private $Status;
private $Won;
private $Time;

function Ticket($idTicket, $idUser, $totalOdd, $placedBet, $possibleWin, $status, $won, $time) {
    $this->IDTicket = $idTicket;
    $this->IDUser = $idUser;
    $this->TotalOdd = $totalOdd;
    $this->PlacedBet = $placedBet;
    $this->PossibleWin = $possibleWin;
    $this->Status = $status;
    $this->Won = $won;
    $this->Time = $time;
}

function getIDTicket(){
    return $this->IDTicket;
}

function setIDTicket($idTicket){
    $this->IDTicket = $idTicket;
}

. . .

I got error Call to a member function getIDTicket() on a non-object

How should it be done?

Just for sanity, add in $nizTiketa = array(); at the top of function showAll() - always initialise your array before adding something into it :) — Joe
– Joe, Commented Feb 9, 2012 at 0:13
The thing is that the variable $nizTiketa will not exist if no rows matched the query. That's strictly speaking an error you'll want to avoid by initializing the variable. — deceze
– deceze ♦, Commented Feb 9, 2012 at 0:19

Phil · Accepted Answer · 2012-02-09 00:21:08Z

1

Couple of things I'd do here for sanity...

As mentioned by Joe, initialise your array before adding elements, eg
```
function showAll() {
    $nizTiketa = array();
    // ...
```

Either initialise your iteration counter $i to zero

for ($i = 0, $count = count($niz); $i < $count; $i++)

or more simply, use foreach

foreach ($niz as $ticket) {
    echo $ticket->getIDTicket(), "<br/>";
}

answered Feb 9, 2012 at 0:21

Phil

166k25 gold badges265 silver badges269 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

OOP in PHP - object array iteration

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related