Call function in array (PHP)

Question

In the building process of an array I'm trying to call a function, checkIfNodeExists(). PHP executes this function and gives me the expected result but he still gives me a "Notice", and I don't want any kind of errors in my code.

function checkIfNodeExists($input) {
   if (isset($input)) {
      return (string) $input;
   } else {
      return 'null';
   }
}

$array['sections'][] = array (
   'ident'       =>  $section->attributes()->ident,
   'title'       =>  $section->attributes()->title,
   'objective'   =>  checkIfNodeExists($section->objectives->material->mattext)
);

Notice: Trying to get property of non-object in /var/www/OLAT_Connection/QTI-XML-Parser.php on line xx

Now, if I check if "objective" exists OUTSIDE the array, PHP doesn't give me a notice. But this results in more lines of code because I have to work with an extra variabele and more IF-structures and so on...

Is there any other possibility without adding too much lines of extra code?

Make sure that $section->objectives->material->mattext is properly initiated and defined. Please note that more code is not necessarily worse! — Ben Carey
– Ben Carey, Commented Mar 26, 2012 at 9:02
maybe you should check with isset before you call checkIfNodeExists — Fivell
– Fivell, Commented Mar 26, 2012 at 9:11

user585756 · Accepted Answer · 2012-03-26 09:20:09Z

2

The problem is that when you call checkIfNodeExists you send it a value, and by sending it the value you also execute the value. So isset() will work on the result of the expression $section->objectives->material->mattext and not the expression itself.

This would work:

$array['sections'][] = array (
   'ident'       =>  $section->attributes()->ident,
   'title'       =>  $section->attributes()->title,
   'objective'   =>  isset($section->objectives->material->mattext) ? (string)$section->objectives->material->mattext : 'null'
);

answered Mar 26, 2012 at 9:20

user585756

Sign up to request clarification or add additional context in comments.

Comments

Ben Carey · Accepted Answer · 2012-03-26 09:14:08Z

1

It seems that $section->objectives->material->mattext is not properly defined. I would start looking there to see if you have errors in the initialisation of the object.

It would be better if you posted more code up so we can see what exactly is going on in this script.

The solution may require more code (albeit unlikely in this case), this is by no means a bad thing. Less code is not necessarily better or more efficient! Obviously it goes without saying that fewer lines of code will (most of the time) execute faster, but this does not make it more secure or efficient

UPDATE

You may be able to simply do this instead of calling another function:

'objective' => isset($section->objectives->material->mattext) ? (string)$section->objectives->material->mattext : null

I have not tested this and cannot remember whether you can place conditional statements inline, so cannot be sure whether it will work but if it does then this will be more efficient, and it is less code!

answered Mar 26, 2012 at 9:14

Ben Carey

17k20 gold badges95 silver badges181 bronze badges

2 Comments

Joey Lemmens Over a year ago

Well Halleluja, the conditional works. However I understand that more code isn't necessarily bad. Thanks!

Ben Carey Over a year ago

Glad I could help, enjoy! :-)

capn3m0 · Accepted Answer · 2012-03-26 09:03:54Z

0

if you add "@" when you call the function the error aren't show

    function checkIfNodeExists($input) {
   if (isset($input)) {
      return (string) $input;
   } else {
      return 'null';
   }
}

$array['sections'][] = array (
   'ident'       =>  $section->attributes()->ident,
   'title'       =>  $section->attributes()->title,
   'objective'   =>  @checkIfNodeExists($section->objectives->material->mattext)
);

answered Mar 26, 2012 at 9:03

capn3m0

1

1 Comment

Ben Carey Over a year ago

Yes, but this just suppresses the error. The function is not doing what he wants so this does not sort it!

Othman Abahossain · Accepted Answer · 2012-03-26 09:05:07Z

0

Define $section->objectives->material->mattext

answered Mar 26, 2012 at 9:05

Othman Abahossain

8110 bronze badges

Collectives™ on Stack Overflow

Call function in array (PHP)

4 Answers 4

Comments

2 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related