problem with find (shell script)

Question

I want the files of a given directory and use the following script:

echo "give name of directory: "
read directory
if  [ -d "$directory"   ]
then 
echo "thanks again"
else exit
fi
find  /-type f $directory

Unfortunately this does not work.

Ijaz Ahmad · Accepted Answer · 2016-01-07 14:12:29Z

1

find $directory -type f

that will find all the files in that directory including any sub directories

answered Jan 7, 2016 at 14:12

Ijaz Ahmad

7,4107 gold badges35 silver badges46 bronze badges

user732 · Accepted Answer · 2016-01-07 14:12:38Z

1

I'm guessing here, but this might be what you want:

echo "give name of directory: " 
read directory 
if [ -d "$directory" ]
then 
    echo "thanks again" 
else 
    exit 
fi 
find $directory -type f

You had find looking in /, the root directory.

answered Jan 7, 2016 at 14:12

user732

Lambert · Accepted Answer · 2016-01-07 14:17:59Z

0

The find command is wrongly written:

find  /-type f $directory

Should be:

find "$directory" -type f

Note that the find command is recursive. If you are only interested in files in the exactly given directory use:

find "$directory" -maxdepth 1 -type f

And finally to add a little simpler version:

echo "give name of directory: "
read directory
if  [ -d "$directory" ]
then 
    echo "thanks again"
    find  "$directory" -maxdepth 1 -type f
fi

answered Jan 7, 2016 at 14:12

Lambert

12.8k2 gold badges28 silver badges35 bronze badges

3 Answers 3