Help with if statement inside while loop

Question

I have the following snippet of code, basically I get the set value of id from the metabox, get the current id based on the loop, try and match, if htey match I want to pull the values from the matched id, currently i can only get the id, but i would like to get the associated custom field values of that post as well.

Also I don't know why, even if it matches the value, it will still echo out the else statement twice, i guess cause it's in the while loops, but how do i get ride of that?

<?php 
                  $list_agent = get_post_meta( $post->ID,'ec_agents',true );    
                  $args = array( 'post_type' => 'agent_type');  

                    $the_query = new WP_Query( $args );
                    $id = $post->ID;
                    while ( $the_query->have_posts() ) : $the_query->the_post();

                        if ($id == $list_agent) {
                            echo "success";
                            the_title();

                            //Both Meta values not showing
                            echo get_post_meta( $post->ID,'_agent_phone',true );
                            echo get_post_meta( $post->ID,'_agent_email',true );
                        } else {
                            echo "better luck next time";
                        }
                    endwhile;

                    wp_reset_postdata();
                    ?>

Milo · Accepted Answer · 2012-11-19 01:46:53Z

1

You're setting $id = $post->ID; outside of the loop for agent_type posts, it'll never match.

Anyway, if you're not doing anything with the agent_type posts that don't match, just query for the one post you want by its ID:

$list_agent = get_post_meta( $post->ID,'ec_agents',true );
$args = array(
    'post_type' => 'agent_type',
    'p' => $list_agent
);
$agent_query = new WP_Query( $args );
while ( $agent_query->have_posts() ) : $agent_query->the_post();
    echo get_post_meta( get_the_ID(),'_agent_phone',true );
    echo get_post_meta( get_the_ID(),'_agent_email',true );
endwhile;
wp_reset_query();

edited Nov 19, 2012 at 1:46

answered Nov 19, 2012 at 1:34

Milo

79.1k4 gold badges128 silver badges172 bronze badges

see edited code above, maybe I misunderstood what you're trying to do?

Milo
– Milo

2012-11-19 01:47:22 +00:00
Commented Nov 19, 2012 at 1:47
oh never mind, you figured it out!

Milo
– Milo

2012-11-19 01:48:30 +00:00
Commented Nov 19, 2012 at 1:48

Add a comment |

Stack Exchange Network

Help with if statement inside while loop

1 Answer 1

Your Answer

Hot Network Questions

Help with if statement inside while loop

1 Answer 1

Your Answer

Sign up or log in

Post as a guest

Related

Hot Network Questions