PHP array variables being assigned values

Question

I am fairly new to PHP and Codeigniter so im sure this will be simple.

I have contact details stored in this format where type is either (1,2,3,4) mapping to (facebook, mobile, bbm, msn, twitter):

ID | USERID | TYPE | VALUE
1  |    8   |  2   | 076773635

I have set up a model to access these contact details, there may be none, or at best one of each type;

function getContactDetails($userid) {
    $query = $this->db->query("SELECT * FROM who_user_contact_info WHERE userid=".$userid);

    foreach ($query->result() as $row)
    {
        switch ($row->type) {
            case 1:
                $contact['facebook'] = $row->value;  
            case 2:
                $contact['mobile'] = $row->value; 
            case 3:
                $contact['bbm'] = $row->value; 
            case 4:
                $contact['msn'] = $row->value;  
            case 5:
                $contact['twitter'] = $row->value; 
        }

    }


    return $contact;
}

My controller then passed this data to my view;

<h3>Contact Info</h2>
<?php   
    echo "Facebook: ". $facebook ."<br />";
    echo "mobile:".  $mobile ." <br />";
    echo "bbm:".  $bbm ." <br />";
    echo "msn:".  $msn ." <br />";
    echo "Twitter:".  $twitter ." <br />";
?>

This seems to nearly work, but there must be a mistake, as for example say type 3 and 5 didn't exist, mobile and twitter shouldn't have been assigned anything! yet on my output it gives the value from the one before, eg bbm=mobile and twitter=msn.

How is it possible for these array to be there when the case has not set them? or is my logic wrong?

While your answer is any of the break; answers, you can return from the switch (and presumably remove the foreach), as your code suggests getContactDetails() will only ever accept a single $userid. If that were the case, you wouldn't need the break; as each case would itself return from the function. — Dan Lugg
– Dan Lugg, Commented Apr 4, 2012 at 13:23

RoyalFool · Accepted Answer · 2012-04-04 13:00:50Z

7

Don't you need to put a break under each case?

case 1:
$contact['facebook'] = $row->value;  
break;

etc

answered Apr 4, 2012 at 13:00

RoyalFool

2462 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

saluce · Accepted Answer · 2012-04-04 13:02:07Z

0

You need a break; in each case after setting the variable.

answered Apr 4, 2012 at 13:02

saluce

13.4k3 gold badges52 silver badges68 bronze badges

Collectives™ on Stack Overflow

PHP array variables being assigned values

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related