How to escape text coming from PHP in JavaScript?

Question

I am using jPlayer to display some videos and I create the playlist on the fly in a php foreach statement:

var playlistacting = 
            [
        <?php foreach($this->result as $val){?>
                {
                    title:  '<?php echo $val->getTitle();?>',
                    artist: '<?php echo $val->getDes();?>',
                    poster: "<?php echo $val->getVideoId();?>.jpg",
                    thumb:  "<?php echo $val->getVideoId();?>.jpg",
                    flv:    "<?php echo $val->getVideoId();?>.flv",
                },
        <?php }?>
];

and $val->getDes() example would be I have a one-hour (approximately) solo musical revue called "Manhattan With A Twist". The entire...

the error I get is

unterminated string literal
[Break On This Error]   

artist: 'I have a one-hour (approximately)solo musical revue called "Manhattan W...

jquery.js (line 2, col 32)

and is poining to the ' at the beginning of the string.

I can do this: title: "<?php echo htmlspecialchars($val->getTitle());?>",

and I will get the same error but with " instead of '.

I'm not sure what is happening here. Is it complaining about that ' not being escaped or what?

Any ideas?

Have you considered using json_encode()?

NullUserException
– NullUserException

2012-04-04 20:54:47 +00:00
Commented Apr 4, 2012 at 20:54 — NullUserException
– NullUserException, Commented Apr 4, 2012 at 20:54

Dr.Molle · Accepted Answer · 2012-04-04 20:55:07Z

4

simply use json_encode:

var playlistacting = <?php echo json_encode($this->result);?>;

answered Apr 4, 2012 at 20:55

Dr.Molle

117k16 gold badges200 silver badges206 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Patrioticcow Over a year ago

i can see using it on a array, but why is working on this string

Dr.Molle Over a year ago

It's not working on a string, it's working on an array/object that contains strings.

Spudley Over a year ago

I don't know why this worked. json_encode() is the right answer, but from what you've shown us of your result object, it won't produce all the right data just with a single call to json_encode(). I would expect you'd need to build a PHP array first from $this->result into the format you want, and json_encode() that.

Dr.Molle Over a year ago

@Spudley: that's correct, the file-extensions are missing. But they seem to be static, so they also may be appended in javascript later when they are needed.

Patrioticcow Over a year ago

@Spudley it works perfect, the text comes back with all quotes and everything.

|

Collectives™ on Stack Overflow

How to escape text coming from PHP in JavaScript?

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related