PHP class function not working

Question

I'm new to PHP and web scripting in general so this a newb question.

Currently i'm a creating an instance to an object, yet when I call the constructor the script slienty shuts down... it doesn't call the next function and I don't know why. Any help would be welcome.

Here is the code.

<?php
class product {
    var $ssProductName;
    var $ssVendorName;
    var $ssDescr;
    var $ssURI;

    // Clean constructor, strings must be cleaned before use
    function __construct($ssProd, $ssVendor, $ssD, $ssU) {
        $this->$ssProductName = $ssProd;
        $this->$ssVendorName = $ssVendor;
        $this->$ssDescr = $ssD;
        $this->$ssURI = $ssU;
    }

    // print a table of the values
    function DisplayOneEntry() {

        echo '<table border="1">
                    <tr>
                    <td>'.$this->$ssProductName.'</td>
                    <td>'.$this->$ssVendorName.'</td>
                    <td>'.$this->$ssDescr.'</td>
                    <td>'.$this->$ssURI.'</td>
                    </tr>
                    </table>';
    }

}

echo "<HTML>";
echo "A";
$newP = new product("Redhat", "Redhat corp", "Leader in", "www.redhat.com");
echo "B";
$newP->DisplayOneEntry();

echo "</HTML>";
?>

But the output is just:

<HTML>
A

Then nothing else.

This is running on a hosting provider using php 5.2.9 and Apache 2.2.

I take it you forgot the leading <?php ? Btw, the trailing ?> is not necessary. — phihag
– phihag, Commented Jun 16, 2009 at 21:38
It looks like you have display_errors set to Off, or error_reporting showing nothing, or both of these problems. — David Snabel-Caunt
– David Snabel-Caunt, Commented Jun 16, 2009 at 21:40
I think the var keyword is deprecated in 5. Turn your errors on and provide those please :) through error_reporting(E_ALL) — Aiden Bell
– Aiden Bell, Commented Jun 16, 2009 at 21:40
There also seems to be missing ' on the end of your <td> You need to escape the line return — Aiden Bell
– Aiden Bell, Commented Jun 16, 2009 at 21:45

jbradaric · Accepted Answer · 2010-10-23 00:06:23Z

9

You need to access the member variables with:

$this->variableName

Not:

$this->$variableName

edited Oct 23, 2010 at 0:06

Roger Pate

answered Jun 16, 2009 at 21:40

jbradaric

8561 gold badge9 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user123942 Over a year ago

Thankyou all for your help. And yes now I have display_error turned on. :-)

Galen · Accepted Answer · 2009-06-16 21:41:31Z

3

    $this->$ssProductName = $ssProd;

should be

    $this->ssProductName = $ssProd;

no $ after the ->

answered Jun 16, 2009 at 21:41

Galen

30.2k9 gold badges75 silver badges90 bronze badges

Comments

Gumbo · Accepted Answer · 2009-06-16 21:41:44Z

1

The syntax $this->$foo is a variable variable referencing the class attribute with the name of the value of $foo. So if $foo has the value bar, $this->$foo would reference $foo->bar and not $this->foo.

So just remove the $ after $this-> and it should work.

answered Jun 16, 2009 at 21:41

Gumbo

657k112 gold badges792 silver badges852 bronze badges

Comments

phihag · Accepted Answer · 2009-06-16 21:43:17Z

0

That is because your php script is erroneous. To catch such errors, you should run it on a debugging server (with display_errors set to On) or use other logging methods.

However, the main problem is you are accessing object members the wrong way; there's no second dollar sign. Instead of

$this->$ssProductName = $ssProd;

use

$this->ssProductName = $ssProd;

answered Jun 16, 2009 at 21:43

phihag

289k75 gold badges475 silver badges489 bronze badges

Collectives™ on Stack Overflow

PHP class function not working

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related