Java - Search and Replace part of a String

Question

I wanted to write a short programm, which replaces the Counting of a String. So I would like to start the String with 0 insted of 1. And Because it is a long String i dont want to change it all by my own. So the String (in this example) is: String LINE:

Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore
magna aliquyam erat, sed diam voluptua.
At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum
dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore
magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren,
no sea takimata sanctus est Lorem ipsum dolor sit amet.

And I want the String to start the counting with 0.

    public static void main(String[] args) {


    int Counter = 1;

    while (Counter <=300){
        int counter2 =1;
        String Counterstring ;
        Counterstring = (new Integer(counter2)).toString() + ".";
        int ReplaceCounting = 0;
        String Replace = (new Integer(ReplaceCounting)).toString() + ".";
        Line.replace(Counterstring , Replace);

        Counter++;

    }

    System.out.println(Line);

}

}

Can somebody tell me what I did wrong? The output is just the same.

EDIT:

I changed it into: I changed it in:

   public static void main(String[] args) {




    for (int counter = 1; counter <= 300; counter++) {

        int NormCounter =1;
        int ReplaceCounter = 0;

        String NormCounterS  = (new Integer(NormCounter)).toString() + ".";


        String ReplaceCounterS = (new Integer(ReplaceCounter)).toString() + ".";
        Line = Line.replace(NormCounterS , ReplaceCounterS);
        ++ReplaceCounter;

        ++NormCounter;



    }

    System.out.println(Line);

}

}

But it still changes the first "1." into "0."... So its 0,2,3,4... But i want the counting to go 0,1,2,3,4

Jon Skeet · Accepted Answer · 2012-04-07 08:14:29Z

5

You're assuming that strings are mutable. They're not. Calling replace and then ignoring the return value will do nothing useful. You want:

Line = Line.replace(Counterstring, Replace);

Although for preference, you should use camelCase for variable names, and avoid doing a lot of work for no reason. For example, your loop would be better as:

for (int counter = 1; counter <= 300; counter++) {
    line = line.replace("1.", "0.");
}

It's not clear why you'd want to do it multiple times, of course... your description is pretty obscure to me, I'm afraid.

EDIT: With your edited code, it looks like you really want:

for (int counter = 1; counter <= 300; counter++) {
    line = line.replace(counter + ".", (counter - 1) + ".");
}

edited Apr 7, 2012 at 8:14

answered Apr 6, 2012 at 23:06

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Ahmad Over a year ago

I changed it in: public static void main(String[] args) { int Counter = 1; while (Counter <=300){ int counter2 =1; String Counterstring ; Counterstring = (new Integer(counter2)).toString() + "."; int ReplaceCounting = 0; String Replace = (new Integer(ReplaceCounting)).toString() + "."; Line = Line.replace(Counterstring , Replace); ++ReplaceCounting; ++Counter; ++counter2; } System.out.println(Line); } } But it still changes the first "1." into "0."... So its 0,2,3,4... But i want the counting to go 0,1,2,3,4

trutheality Over a year ago

@user1253575 Don't paste code into comments. Add an update to your question instead.

Jon Skeet Over a year ago

@user1253575: I see you've completely ignored the advice about variable names... and you're still creating new Integer objects for no reason. The problem now is that you're starting NormCounter and ReplaceCounter again on each iteration of the loop. I've edited my answer - if that doesn't work, please show a short but complete example of it failing.

Ahmad Over a year ago

ah I see now.. your right, it would be better with your code. Thanks :)

Tim Pote · Accepted Answer · 2012-04-07 05:05:39Z

2

First off, like Jon said, not having proper camelCase for your variables makes your code almost unreadable for regular Java users. Any new code you post should really use the established conventions.

Now, as for your code, you're resetting your counters every time you iterate through the loop. So every time you get to line.replace(normCounter, replaceCounter) it's doing line.replace("1.", "0.")

Here's what you should have done:

int replaceCounter = 0;
for (int counter = 1; counter <= 300; counter++) {
  line = line.replace(String.valueOf(counter) + ".", String.valueOf(replaceCounter) + ".");
  replaceCounter++;
}

System.out.println(line);

Notice how I initialized my counter outside of my for-loop.

answered Apr 7, 2012 at 5:05

Tim Pote

28.4k6 gold badges66 silver badges68 bronze badges

Collectives™ on Stack Overflow

Java - Search and Replace part of a String

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related