echo a javascript function with parameters in php

Question

I am trying to pass a JavaScript function with an onclick event in php. The problem I am facing is that the function that I need to pass has a parameter that needs to be in double quotes as follows:

onclick="removeElement("div8")"

Now when I use JavaScript to generate the parameter it comes out fine, but whenever I use an echo function in php, the following happens when I look at the function in the browser

onclick="removeElement(" div8")"

the code I am using to generate this is:

echo '<div><img src="img.png" alt="image" onclick="removeElement("div'.$x.'")" /></div>';

where $x is the number to be added to the parameter.

Is there a way that the function is returned as a whole and not get the space in between?

Niet the Dark Absol · Accepted Answer · 2012-04-09 20:21:14Z

9

This is happening because you have quotes inside quotes. This will not work, and breaks the HTML parser. It is seeing the onclick as removeElement(, and then it sees an attribute called div8")".

Try this:

echo '.....onclick="removeElement(&quot;div'.$x.'&quot;)"...';

HTML entities are parsed inside attributes, so the result will be your working code.

answered Apr 9, 2012 at 20:21

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bobby Axe Over a year ago

For single quotes use ' For double quotes use " @niet a big thank you.

hjpotter92 · Accepted Answer · 2012-04-09 20:20:43Z

2

Change your echo to this:

echo '<div><img src="img.png" alt="image" onclick="removeElement(\'div'.$x.'\')" /></div>';

answered Apr 9, 2012 at 20:20

hjpotter92

81.1k36 gold badges148 silver badges188 bronze badges

Comments

Dima · Accepted Answer · 2012-04-09 20:23:08Z

2

You must escape quotes in javascript. Instead of

onclick="removeElement("div8")"

you should write

onclick="removeElement(&quot;div8&quot;)"

answered Apr 9, 2012 at 20:23

Dima

1,76115 silver badges35 bronze badges

Comments

Dutchie432 · Accepted Answer · 2012-04-09 20:21:25Z

1

try escaping your single-quotes

echo '<div><img src="img.png" alt="image" onclick="removeElement(\'div'.$x.'\')" /></div>';

answered Apr 9, 2012 at 20:21

Dutchie432

29.3k20 gold badges94 silver badges110 bronze badges

2 Comments

Dutchie432 Over a year ago

what are you talking about? You are escaping the quotes in javascript, not HTML.

Keleb Over a year ago

when viewed from the browser the HTML will show with the \ still in the function thus will not work

Koen Peters · Accepted Answer · 2012-04-09 20:22:00Z

1

As long as you do not use any spaces in the attribute value you can ommit the quotes around the html attribute values. All browsers will handle that fine. So you can write:

onclick=removeElement("div8")

You could also use the single quotes:

onclick="removeElement('div8')" or 
onclick='removeElement("div8")'

Or you can escape the double quote:

echo '<div><img src="img.png" alt="image" onclick="removeElement(\"div'.$x.'\")" /></div>';

answered Apr 9, 2012 at 20:22

Koen Peters

12.9k6 gold badges40 silver badges62 bronze badges

6 Comments

Dima Over a year ago

Quotes must be replaced with ", using " in this context is incorrect.

Dima Over a year ago

I'm sure it works, but this is incorrect code. Don't blame me if it won't work in some browser, and don't blame IE ;)

Keleb Over a year ago

@Dima Thanks for the tip, but at the moment I am using Chrome and it works fine, but have not tried it on other browsers :)

Koen Peters Over a year ago

@Dima: You are right. It is not correct as in: it won't validate when you use a doctype other than HTML5. But I think that does not matter as browsers accept it anyway. Just use HTML5 doctypes and you'll be find. HTML5 doesn't care. :)

Dima Over a year ago

Well, @koenp, if nobody cares we will have same situation: everyone will blame IE (or some other browser), while they keep writing invalid code. Standards are created to be followed.

|

CodePorter · Accepted Answer · 2012-11-14 14:01:03Z

0

But a simpler solution would be to write in html directly:

?>
<div>
 <img src='img.png' alt='image' onclick='removeElement("div<?php echo $x; ?>")' />
</div>

edited Nov 14, 2012 at 14:01

answered Apr 9, 2012 at 20:37

CodePorter

2401 gold badge3 silver badges13 bronze badges

Comments

zratan · Accepted Answer · 2017-06-04 02:57:29Z

0

when you using php echo try this code

<a href="javascript:add_cota(<?php echo $value->ID .','.$k.', \''.$st.'\'';?>)">

$st is the string param to avoid the ReferenceError: Active is not defined error

answered Jun 4, 2017 at 2:57

zratan

8668 silver badges12 bronze badges

Collectives™ on Stack Overflow

echo a javascript function with parameters in php

7 Answers 7

1 Comment

Comments

Comments

2 Comments

6 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

1 Comment

Comments

Comments

2 Comments

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related