Change Color of Div Dynamically - Javascript

Question

I think this should be a simple question, but I'm having trouble figuring it out. I have two divs within a parent div and I want to change the color of just the right div (javascript). My code loops through the child divs and then changes the color of both. I can't figure out how to select just the right div and change its color. Here is my code (this changes the color of both):

    var color = "#fdd42e";
    var element = document.getElementById(user_id).childNodes;

    for (i=0;i< element.length;i++) {

        if(element[i].id = 'right') {
            element[i].style.background = color;
        }
        else {
        }

    }

Your i variable is global which is a very bad thing (imagine calling another function which also loops over i inside that loop). Use for(var i = 0; ....) instead — ThiefMaster
– ThiefMaster, Commented Apr 10, 2012 at 10:35
Why not give the desired div an id or name so you can reference it directly...? — Dutchie432
– Dutchie432, Commented Apr 10, 2012 at 10:35

Sarfraz · Accepted Answer · 2012-04-10 10:35:24Z

5

I can't figure out how to select just the right div and change its color.

Use == instead of =:

if(element[i].id = 'right') {
                 ^
            -----|

answered Apr 10, 2012 at 10:35

Sarfraz

384k81 gold badges561 silver badges613 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

mkyong Over a year ago

I knew it would be something simple. Thanks!

Collectives™ on Stack Overflow

Change Color of Div Dynamically - Javascript

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related