PHP: mysql query gives a boolean

Question

<?php
class Page {
    function getPage($urlOfPage){
        $result = mysql_query('SELECT category, title FROM rs-planet WHERE url = "'.  mysql_real_escape_string($urlOfPage));
        if(mysql_num_rows($result) === 0){
            header('HTTP/1.0 404 Not Found');
            exit;
        }
        else{
            return $page[] = mysql_fetch_array($result);
        }
    }
}

?>

And I have this errors:

Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in C:\xampp\htdocs\rs-planet\classes\page.php on line 6

Warning: mysql_fetch_array() expects parameter 1 to be resource, boolean given in C:\xampp\htdocs\rs-planet\classes\page.php on line 11 And I don't see the problem...

And if I do var_dump @ $result I get a boolean. (If it's founded @ the db it gives true, if it isn't it gives me false.)

PS. Sorry for my bad English, my main language is Dutch.

EDIT: var_dump(mysql_error) =

string(152) "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '"index' at line 1"

No closing quotes for the url string value in your SQL query... when will people learn to debug their sql queries, even if they can't be persuaded to enter the 21st century and use prepared statements — Mark Baker
– Mark Baker, Commented Apr 10, 2012 at 21:56
Yup. Prepared statements are a gift from the SQL gods - USE THEM. :) — kitti
– kitti, Commented Apr 10, 2012 at 22:00
Using PDO, which encourages placeholders, is a really good idea. — tadman
– tadman, Commented Apr 10, 2012 at 22:22
possible duplicate of Warning: mysql_fetch_* expects parameter 1 to be resource, boolean given error — j0k
– j0k, Commented Jul 29, 2012 at 7:25

kitti · Accepted Answer · 2012-04-10 22:25:05Z

2

mysql_query returns false if the query cannot be executed (i.e. bad syntax). Try surrounding rs-planet with backticks:

$result = mysql_query('SELECT category, title FROM `rs-planet` WHERE url = "'.  mysql_real_escape_string($urlOfPage) . '"');

I'm thinking the - in the table name is screwing up the syntax.

EDIT: Also, PDO makes it much easier to debug these issues since you don't need to use mysql_error() to get the error message - it's included in the Exception thrown by PDO. http://php.net/manual/en/book.pdo.php

SECOND EDIT: Actually the problem is likely the missing quote. Fixed my code, but see the other answers...

edited Apr 10, 2012 at 22:25

answered Apr 10, 2012 at 21:53

kitti

14.9k33 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

dotancohen Over a year ago

The query syntax is not fine, it is missing the close quote.

kitti Over a year ago

@citizenen Actually the missing quote is probably the problem, as noted in the other answers.

kitti Over a year ago

@Robin Sorry, had the concat outside the function call; fixed now.

Andrew Leach · Accepted Answer · 2012-04-10 21:55:41Z

1

mysql_query returns false on an error.

You have WHERE url=" but no closing quote after the url string.

answered Apr 10, 2012 at 21:55

Andrew Leach

13k1 gold badge44 silver badges48 bronze badges

Comments

dotancohen · Accepted Answer · 2012-04-10 21:55:53Z

1

mysql_query returns FALSE on error. Your error is that you are not closing the quote in your query. Try this:

        $result = mysql_query('SELECT category, title FROM rs-planet WHERE url = "'.  mysql_real_escape_string($urlOfPage).'"');

answered Apr 10, 2012 at 21:55

dotancohen

31.8k43 gold badges147 silver badges208 bronze badges

1 Comment

dotancohen Over a year ago

Also, try return $page instead of return $page[]. The former will return the array from mysql_fetch_array, the later will return the array from mysql_fetch_array in the first element of the $page array.

Collectives™ on Stack Overflow

PHP: mysql query gives a boolean

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related