How to solve this javascript function

Question

i am calling this function

   el=DOM.create({tag:"div",css:{backgroundColor:"#000000",color:"green"},html:"abc"});
   $("#fb_dv").append(el);

my function is here

DOM={
    create:function(data){
        if(data.tag){
            d=document;
            doc=d.createElement(data.tag);
            for(var v in data){
                 if(v=="css"){
                     for(key in data[v]){
                        prop=doc.style;
                        prop.key=data[v][key]
                     }
                 }
                 if(v=="html"){
                     doc.innerHTML=data[v]
                 }
            }

            return doc;
        }
    }
}

The problem is that this function is not setting css properties

The second line, using $.append() is your own library?

Sampson
– Sampson

2012-04-13 14:58:53 +00:00
Commented Apr 13, 2012 at 14:58 — Sampson
– Sampson, Commented Apr 13, 2012 at 14:58
yes i have created it but problem is with DOM function

user1331534
– user1331534

2012-04-13 14:59:50 +00:00
Commented Apr 13, 2012 at 14:59 — user1331534
– user1331534, Commented Apr 13, 2012 at 14:59

James Allardice · Accepted Answer · 2012-04-13 14:59:03Z

3

The problem is in the for loop that should set the styles. You need to use the square bracket syntax to set the correct property:

for(key in data[v]){
    prop = doc.style;
    //prop.key = data[v][key]... change this to this:
    prop[key] = data[v][key];
}

Here's a working example.

As a side note, you have a lot of missing var statements so all of your variables are leaking into the global scope, and you also have a lot of missing semi-colons.

answered Apr 13, 2012 at 14:59

James Allardice

166k22 gold badges335 silver badges316 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

James Allardice Over a year ago

You are missing them after prop.key=data[v][key], doc.innerHTML=data[v] and after the closing } of DOM.

Collectives™ on Stack Overflow

How to solve this javascript function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related