add button from javascript with an onclick function that takes multiple parameters

Question

I am trying to add a button from a javascript function (with the innerHTML method) that has another function as the onClick function. This onClick function has to take multiple parameters:

area.innerHTML += "<input type='image' src='images/del.jpg' width='15' height='15' " +
           "onClick='del(" + info['_id'] + "," + key + "," + value + ")' />";

This is (I think) the most logical way to do this, but when I try to click the button there is no functioncall. This works with one single argument, so the problem has to be in the combination of the parameters with the ",". Does anybody know how to solve this?

update The del function is a temporary testfunction

function del(id, key, value) {
    console.log(id + key + value);
}

It looks to me like it should work. Are you able to post the code to your del function? — blocco
– blocco, Commented Apr 13, 2012 at 23:54
Are there any errors? What types of data are info[_id], key and value? — blocco
– blocco, Commented Apr 14, 2012 at 0:04
<button><img src="del.jpg"></button> is better than <input type="image"> (but needs style hacks if you're forced to cater to IE6). Attaching event handlers from external JS is better than using inline onclick handlers. Inspecting the attributes and the DOM to find your id, key, and value is better than string concatenation. In summary, using your (JS) controller to manipulate your view (the DOM) is better than mixing the two together. IMHO. (my humble opinion is based on 20 years of event-driven programming. take it as you will.) — Stephen P
– Stephen P, Commented Apr 14, 2012 at 0:12
info[_id], key and value are normal strings and were tested upfront an d there aren't any errors — JasperTack
– JasperTack, Commented Apr 14, 2012 at 0:30

hjpotter92 · Accepted Answer · 2012-04-14 00:12:02Z

3

I think you just need your variabled to be passed as strings. Edit the onclick even to this:

onClick='del(\"" + info['_id'] + "\",\"" + key + "\",\"" + value + "\")' />"

answered Apr 14, 2012 at 0:12

hjpotter92

81.1k36 gold badges148 silver badges188 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

add button from javascript with an onclick function that takes multiple parameters

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related