PHP: return a part of an if () { }

Question

Let's say I have this code:

if (md5($_POST[$foo['bar']]) == $somemd5) {
  doSomethingWith(md5($_POST[$foo['bar']]);
}

I could shorten that down by doing:

$value = md5($_POST[$foo['bar']];
if ($value == $somemd5) {
  doSomethingWith($value);
}

But is there any pre-set variable that contains the first or second condition of the current if? Like for instance:

if (md5($_POST[$foo['bar']]) == $somemd5) {
  doSomethingWith($if1);
}

May be a unnecessary way of doing it, but I'm just wondering.

what is foo, a typo? Did you mean $foo?

Cole Tobin
– Cole Tobin

2012-05-28 18:15:11 +00:00
Commented May 28, 2012 at 18:15 — Cole Tobin
– Cole Tobin, Commented May 28, 2012 at 18:15
@ColeJohnson you're right, I did mean $foo.

ehm
– ehm

2012-05-28 18:33:26 +00:00
Commented May 28, 2012 at 18:33 — ehm
– ehm, Commented May 28, 2012 at 18:33

smo · Accepted Answer · 2008-09-20 15:29:41Z

7

No, but since the assignment itself is an expression, you can use the assignment as the conditional expression for the if statement.

if (($value = md5(..)) == $somemd5) { ... }

In general, though, you'll want to avoid embedding assignments into conditional expressions:

The code is denser and therefore harder to read, with more nested parentheses.
Mixing = and == in the same expression is just asking for them to get mixed up.

edited Sep 20, 2008 at 15:29

answered Sep 19, 2008 at 13:28

smo

9137 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Alister Bulman Over a year ago

though you gain nothing by doing that, and only make it more complex to read. There are few shortcuts. This is not one.

ehm Over a year ago

So I shouldn't be doing this, Topbit?

smo Over a year ago

I agree this is not exactly "best practice", but I felt the disclaimer at the end of the question, "may be unnecessary...i'm just wondering", gave me some leeway.

smo Over a year ago

In most cases you'll want to use your second example.

Zsolt Szeberenyi · Accepted Answer · 2008-09-19 13:30:20Z

1

Since the if is just using the result of an expression, you can't access parts of it. Just store the results of the functions in a variable, like you wrote in your second snippet.

answered Sep 19, 2008 at 13:30

Zsolt Szeberenyi

4372 silver badges6 bronze badges

Comments

Paweł Hajdan · Accepted Answer · 2008-09-19 13:36:26Z

1

IMHO your 2nd example (quoting below in case someone edits the question) is just ok. You can obscure the code with some tricks, but for me this is the best. In more complicated cases this advise may not apply.

$value = md5($_POST[foo['bar']];

if ($value) == $somemd5) {
 doSomethingWith($value);
}

answered Sep 19, 2008 at 13:36

Paweł Hajdan

18.6k9 gold badges54 silver badges65 bronze badges

Collectives™ on Stack Overflow

PHP: return a part of an if () { }

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related