PHP XML removing elements

Question

My xml looks like this:

<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<images>
    <pic>
        <image>54</image>
        <descr>Image 1</descr>
    </pic>
    <pic>
        <image>32</image>
        <descr>Image 2</descr>
    </pic>
    <pic>
        <image>47</image>
        <descr>Image 3</descr>
    </pic>
</images>

I want to remove one element, for example second pic (image 32). Using this code, but it's not working.

$xml = simplexml_load_file('../../images.xml');

$target = false;
$i = 0;
foreach ($xml->pic as $m) {
  if ($m['image']=='32') { $target = $i; break; }
  $i++;
}
if ($target !== false) {      //$target always be $false
  unset($xml->pic[$target]);
}

echo $xml->savexml();

Thanks for any advice.

Baba · Accepted Answer · 2012-04-17 22:47:14Z

1

Observations

$m is object not array so $m['image'] should be changed to $m->image

Change $target = false; to $target = 0 ;

Example

$xml = simplexml_load_file ( '1.xml' );
$target = 0;
$i = 0;
foreach ( $xml->pic as $m ) {
    if ($m->image == '32') {
        $target = $i;
        break;
    }
    $i ++;
}

if ($target !== false) {
    unset ( $xml->pic [$target] );
}
echo $xml->savexml ();

edited Apr 17, 2012 at 22:47

answered Apr 17, 2012 at 22:35

Baba

95.3k29 gold badges172 silver badges222 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Sam Dufel Over a year ago

This will not work. His original test for target was fine - this code will always delete the 2nd pic.

Baba Over a year ago

+1 thanks @Sam Dufel .. just notice the dependency on $i change my script

Paul Sullivan · Accepted Answer · 2012-04-17 22:28:30Z

0

Your test is wrong

if ($target !== false) {

should be

if ($target > 0) {

answered Apr 17, 2012 at 22:28

Paul Sullivan

2,8752 gold badges21 silver badges25 bronze badges

2 Comments

Paul Sullivan Over a year ago

!== tests for same value AND type. 0 is never !== false (boolean and int).

Sam Dufel Over a year ago

Reread his code. He's initializing target to false, and setting it to an integer value when he finds the correct index. If target === false, the correct index was never found. Otherwise, target has been set to the index of the element he's deleting (and 0 is a valid index).

Fad · Accepted Answer · 2012-04-18 05:30:24Z

0

Try creating a new XML object, and add only the data you want and save the new object.

edited Apr 18, 2012 at 5:30

Fad

9,8683 gold badges48 silver badges65 bronze badges

answered Apr 17, 2012 at 22:28

Andreas Linden

12.8k7 gold badges54 silver badges70 bronze badges

Collectives™ on Stack Overflow

PHP XML removing elements

3 Answers 3

2 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related