javascript confirm popup within PHP while loop not working

Question

I have the following code setup to delete records from my database. It executes fine except for the javascript confirm message which never pops up. It just gets ignored completely and the record gets deleted. Any ideas why?

 connect_to_db();
    $query="SELECT id, date, title, image FROM content ORDER BY date DESC";
    $result=mysql_query($query);
    $message= "Continue?";
    while($row = mysql_fetch_array($result)){
    echo '<div id="delete" align="center">';
    echo '<a href="delete.php?id='.$row['id'].'" onclick = "if (! confirm('.$message.')) { return false; }" ><img src="'.$row['image'].'" style="border:1px solid black; width:100px;"><br>Delete</a>';
    echo '</div>';
}

looks to me there is going to be conflicts with 'message' confirm(\''.$message.'\')) — rlemon
– rlemon, Commented Apr 20, 2012 at 13:47

Niet the Dark Absol · Accepted Answer · 2012-04-20 13:46:56Z

2

Your Continue? message is shown as a bare string in the JavaScript code, which is for obvious reasons invalid.

Try this:

'... onclick="return confirm(&quot;'.$message.'&quot;);" ...'

answered Apr 20, 2012 at 13:46

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

John Conde · Accepted Answer · 2012-04-20 13:47:03Z

1

Looks like a missing quotes issue:

echo '<a href="delete.php?id='.$row['id'].'" onclick = "if (! confirm(\''.$message.'\')) { return false; }" ><img src="'.$row['image'].'" style="border:1px solid black; width:100px;"><br>Delete</a>';

answered Apr 20, 2012 at 13:47

John Conde

220k100 gold badges464 silver badges504 bronze badges

Collectives™ on Stack Overflow

javascript confirm popup within PHP while loop not working

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related