Difference Between Static or NoneStatic Methods in ASP.NET MVC

Question

I need a method that return me some parameters in controllers this is implementation of it:

    public List<Parameter> GetParameters(FormCollection collection) {

        List<Parameter> parameters = new List<Parameter>();
        List<string> parameterNames = new List<string>();

        //Get Parameters Names and Values

        return parameters;
    }

I use this method in all of controllers, So I think about 3 option that I have to define it:

1-For any controller class define it in that controller like this:

public class ProductController : Controller {

   public List<Parameter> GetParameters(FormCollection collection) {

   //

    }
  }

2-Define it in static class as static method:

public static class GeneralMethods {

   public static List<Parameter> GetParameters(FormCollection collection) {

   //

    }
  }

3-Define it as a None Static :

public class GeneralMethods {

   public List<Parameter> GetParameters(FormCollection collection) {

   //

    }
  }

which one is better? which one have better performance? or any other option for define methods that used in many controllers? what is your suggestion?

Performance-wise you are not likely to notice any difference between the three approaches. What do you mean by "better"? For what? Usability? Readability? Maintenance? Something else? — Oded
– Oded, Commented Apr 21, 2012 at 8:30
@Oded I don't know in web, which one is usual or any difference in performance or page load time or server performance — Saeid
– Saeid, Commented Apr 21, 2012 at 8:32
As I said, when in comes to performance you are not going to get any appreciable differences. — Oded
– Oded, Commented Apr 21, 2012 at 8:34
I would go with option 3, not for performance but because you could then extract an interface from that class and mock it when unit testing your controller actions. That said the method itself feels a bit off, it's not clear why you need it in the first place and accessing FormCollection is usually bad practice. — Betty
– Betty, Commented Apr 21, 2012 at 8:37

Manas · Accepted Answer · 2012-04-21 08:51:56Z

5

There will be no performance impact in any of the three. (Though last approach will create separate object each time,it will be gracefully handled by GC).

approach 1: NO, as a standard practice we should not duplicate the code.

approach 2: YES, if your method depends only on the input parameter.

approach 3: YES, if you need to set up some instance variable and your method depends on them.

suggested approach: (approach 1+ approach 3) If this method is common to all of your controller (or most), declare a base controller with this method and inherit all other controller from it.

Static methods will not be a problem as any variable declared with in a method are with in scope of the method.

answered Apr 21, 2012 at 8:51

Manas

2,54221 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Difference Between Static or NoneStatic Methods in ASP.NET MVC

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related