Initialize new strings inside string array

Question

I have been trying to find out if there is a better way to initialize the string array I am using in this code snippet. I was wondering if there was a function, or perhaps some use of new that would make the calling and assignment of all the empty strings in the code unnecessary. So I can initialize them at the same time I create the array.

                    foreach (var unit in unitList)
                    {
                        //Sort units by each army
                        string unitName = unit.UnitName;
                        armyUnits.Add(unitName, unit);

                        //Sort unit properties by unit
                        List<string> properites = new List<string>();

                        string composition        ="";
                        string weaponSkill        ="";
                        string ballisticSkill     ="";
                        string strength           ="";
                        string initiative         ="";
                        string toughness          ="";
                        string wounds             ="";
                        string attacks            ="";
                        string leadership         ="";
                        string savingThrow        ="";
                        string specialRules       ="";
                        string dedicatedTransport ="";
                        string options            ="";
                        string armour             ="";
                        string weapons            ="";


                        properites.AddRange(new string[15]{

                        composition            = unit.Composition,
                        weaponSkill            = unit.WeaponSkill,
                        ballisticSkill         = unit.BallisticSkill,
                        strength               = unit.Strength,
                        initiative             = unit.Initiative,
                        toughness              = unit.Toughness,
                        wounds                 = unit.Wounds,
                        attacks                = unit.Attacks,
                        leadership             = unit.Leadership,
                        savingThrow            = unit.SaveThrow,
                        specialRules           = unit.SpecialRules,
                        dedicatedTransport     = unit.DedicatedTransport,
                        options                = unit.Options,
                        armour                 = unit.Armour,
                        weapons                = unit.Weapons
                        });


                    }

edit: So it looks like you can do new String(unit.Composition.ToCharArray()) inside the array. I don't think that is any more readable or quicker to write though.

  properites.AddRange(new string[1]{
  new String(unit.Composition.ToCharArray())}

Why do you write "new String(unit.Composition.ToCharArray())"? You could write "unit.Composition" directly. — usr
– usr, Commented Apr 21, 2012 at 20:59
Do you require using a List or could you use an array directly? I added a new alternative to my answer. — usr
– usr, Commented Apr 22, 2012 at 12:46

usr · Accepted Answer · 2012-04-22 12:09:37Z

4

                    foreach (var unit in unitList)
                    {
                        //Sort units by each army
                        string unitName = unit.UnitName;
                        armyUnits.Add(unitName, unit);

                        //Sort unit properties by unit
                        List<string> properites = new List<string>();

                        properites.AddRange(new string[15]{

                        unit.Composition,
                        unit.WeaponSkill,
                        unit.BallisticSkill,
                        unit.Strength,
                        unit.Initiative,
                        unit.Toughness,
                        unit.Wounds,
                        unit.Attacks,
                        unit.Leadership,
                        unit.SaveThrow,
                        unit.SpecialRules,
                        unit.DedicatedTransport,
                        unit.Options,
                        unit.Armour,
                        unit.Weapons
                        });


                    }

You don't need the variables at all. Actually, you don't need a list!

                    var properties = new [] {
                        unit.Composition,
                        unit.WeaponSkill,
                        unit.BallisticSkill,
                        unit.Strength,
                        unit.Initiative,
                        unit.Toughness,
                        unit.Wounds,
                        unit.Attacks,
                        unit.Leadership,
                        unit.SaveThrow,
                        unit.SpecialRules,
                        unit.DedicatedTransport,
                        unit.Options,
                        unit.Armour,
                        unit.Weapons,
                    }

A list supports adding and deleting items which seems not to be used here. You also don't need the array count of 15 because the compiler figures it out. You also don't need the array type for the same reason. C# is a pretty terse language!

I also added a final comma after "unit.Weapons" to make all list items symmetric. This compiles just fine and makes copying, pasting and reordering simpler.

edited Apr 22, 2012 at 12:09

answered Apr 21, 2012 at 20:58

usr

172k38 gold badges251 silver badges380 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Amicable Over a year ago

That is a very comprehensive example thanks for taking the time to write it :) I would just be using this list to reference stored values, so an array would work fine. No real performance benefits from what I've read, but nice and neat!

usr Over a year ago

Performance benefits are definitely there (you save two object allocations, an array copy and indirection at each and every access).

Andrea Angella · Accepted Answer · 2012-04-22 01:09:49Z

3

You also don't need to use the AddRange method. You can simply use the collection initialization syntax.

//Sort unit properties by unit
var properites = new List<string>
                     {
                         unit.Composition,
                         unit.WeaponSkill,
                         unit.BallisticSkill,
                         unit.Strength,
                         unit.Initiative,
                         unit.Toughness,
                         unit.Wounds,
                         unit.Attacks,
                         unit.Leadership,
                         unit.SaveThrow,
                         unit.SpecialRules,
                         unit.DedicatedTransport,
                         unit.Options,
                         unit.Armour,
                         unit.Weapons
                     };

answered Apr 22, 2012 at 1:09

Andrea Angella

3712 silver badges8 bronze badges

2 Comments

Amicable Over a year ago

thank you for showing me this example! I had to double check after reading this that it wasn't in plain sight on MSDN (it's not), I did think it was unusual to actually have to use an array.

usr Over a year ago

This is good. I tried to improve even on this solution by updating my answer ;-)

Collectives™ on Stack Overflow

Initialize new strings inside string array

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related