Code of horror:
var namespace = new function ()
{
this.saySomething = new function( something )
{
console.log( something );
};
}
namespace.saySomething( "whatever" );
This outputs "undefined" when I expected it to output "whatever". How come? And what would the fix be? My goal is nothing more than to have a namespace where I put some helper functions.
new function is generally wonky. Rob W's answer is absolutely correct (+1'd), but I would personally go even further and remove all the newing:
var namespace =
{
saySomething: function( something )
{
console.log( something );
}
}
namespace.saySomething( "whatever" );
If you want to be able to create distinct instances, do it the right way:
function Namespace() {}
Namespace.prototype.saySomething = function (something)
{
console.log(something);
}
// Usage:
var foo = new Namespace();
foo.saySomething("Hallllooooo!");
...though you did say "singleton," so I'm guessing this isn't relevant to your goal.
You don't need to use new before the functions. new is only used for instantiating objects, when a constructor is already defined.
Your code should look like:
var namespace = {
saySomething: function(something) {
console.log(something);
}
}
namespace.saySomething("whatever");
Remove new before function(something){...}. Currently, saySomething is an instance of the anonymous constructor.
I would use something like the following because you also want to make sure that namespace doesn't get overridden by some other code.
var namespace = (function() {
return {
saySomething: function(something) {
console.log(something);
}
};
})();
namespace.saySomething("whatever");
This should do it, sample http://jsfiddle.net/Jssxy/
var namespace = {
saySomething : function(something) {
console.log(something);
}
}
namespace.saySomething( "whatever" );
