MySql query error near WHERE

Question

My code is

$user_query = '
     UPDATE  
          users  
     SET  
          `password`="$password",  
          `email`="$email", 
          `position`="$position", 
     WHERE  
          `username`=".$uname."';
$user_result = mysql_query($user_query, $connection);
confirm_query($user_result);

When I run this query it gives me an error:

Database query failed: You have an error in your SQL syntax;
check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE username=".$uname."' at line 7

Can any body help me resolve this error?

there's an extra comma after the position name/value pair. Also, you're missing concatenation marks for the password, email and position variables. — Doug Dawson
– Doug Dawson, Commented May 1, 2012 at 15:12
The quotes are all off too. You use single quotes and expect the var to be used, then double quotes and concatenation. Echo the string to see what you end up with. — jeremyharris
– jeremyharris, Commented May 1, 2012 at 15:13

gen_Eric · Accepted Answer · 2012-05-01 15:13:56Z

6

Your query is in single quotes, so the variables aren't parsed. As you can see in error, the string is literally

`username`=".$uname."

You need to either use double quotes around the enitre thing, to parse variables correctly.

$user_query = "
 UPDATE  
      users  
 SET  
      `password`='$password',  
      `email`='$email', 
      `position`='$position'
 WHERE  
      `username`='$uname'";

Or correctly use the string concatanation operator, ..

$user_query = '
 UPDATE  
      users  
 SET  
      `password`="'.$password.'",  
      `email`="'.$email.'", 
      `position`="'.$position.'"
 WHERE  
      `username`="'.$uname.'"';

As others have noted, there's also an extra , after postion="$position".

answered May 1, 2012 at 15:13

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Yasitha Over a year ago

thank you the error was gone, i was stuck on this for hours, you save my life lol.. thank you again

Lion · Accepted Answer · 2012-05-01 15:11:06Z

2

Remove the comma , before the WHERE clause

answered May 1, 2012 at 15:11

Lion

19.1k22 gold badges83 silver badges111 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:19:08Z

1

Just change quotes, and better escape data with DB driver funcs like mysql_real_escape_string()

Difference between quotes: https://stackoverflow.com/a/3446286/765634

Escaping: http://php.net/mysql_real_escape_string

Complete query:

$user_query = <<<SQL
     UPDATE  
          users  
     SET  
          `password`="{$password}",  
          `email`="{$email}", 
          `position`="{$position}", 
     WHERE  
          `username`="{$uname}"
SQL;

edited May 23, 2017 at 12:19

CommunityBot

11 silver badge

answered May 1, 2012 at 15:11

Electronick

1,1328 silver badges16 bronze badges

Comments

Wladimir Palant · Accepted Answer · 2012-05-02 04:26:56Z

1

There is a trailing comma between position="$position", and the where clause. Remove the comma just before the where clause.

edited May 2, 2012 at 4:26

Wladimir Palant

57.8k12 gold badges100 silver badges129 bronze badges

answered May 1, 2012 at 15:11

MonkeyMonkey

8361 gold badge6 silver badges19 bronze badges

Comments

Darren · Accepted Answer · 2012-05-01 15:11:41Z

0

 UPDATE  
          users  
     SET  
          `password`="$password",  
          `email`="$email", 
          `position`="$position"
     WHERE  
          `username`=".$uname."';

You had a trailing , after position

answered May 1, 2012 at 15:11

Darren

71.2k24 gold badges141 silver badges146 bronze badges

Comments

Charls · Accepted Answer · 2012-05-01 15:12:49Z

0

You have an extra comma after position="$position". Remove that.

answered May 1, 2012 at 15:12

Charls

3191 silver badge9 bronze badges

Collectives™ on Stack Overflow

MySql query error near WHERE

6 Answers 6

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related