Insert session variable into MySQL database

Question

Hey I am new to PHp and I am trying to enter details into my database. I am trying to enter an eventname- which the user enters (POST) and the username of the logged in user.

I have created sessions to store users usernames, the code i have is

$eventname=$_POST['eventname'];
$myusername = $_SESSION['myusername']

$sql = mysql_query("INSERT INTO $tbl_nameVALUES('','$eventname','$_SESSION['myusername'])");

echo "You have been added to the event";

Its the $sql statement which is giving the error? any help would be much appreciated.

Thanks all!

It would be best if you also gave the error message! It looks like a syntax error from where I'm standing. pollirata and Micheal have both answered the question in depth. — Malovich
– Malovich, Commented May 1, 2012 at 19:16
Please stop writing new code with the ancient mysql_* functions. They are no longer maintained and community has begun the deprecation process . Instead you should learn about prepared statements and use either PDO or MySQLi. If you care to learn, here is a quite good PDO-related tutorial. — tereško
– tereško, Commented May 1, 2012 at 19:28

Michael Berkowski · Accepted Answer · 2012-05-01 19:14:04Z

8

There are several potential problems here.

First, you have not escaped eventname against SQL injection. We assume hopefully that myusername is already safe. If it has not been previously filtered, also use mysql_real_escape_string() on $_SESSION['myusername'].

$eventname = mysql_real_escape_string($_POST['eventname']);

// Then you need space before VALUES and are missing a closing quote on $_SESSION['myusername'], which should be in {}
$sql = mysql_query("INSERT INTO $tbl_name VALUES('','$eventname','{$_SESSION['myusername']}')");

Finally, in order for the statement to work, it assumes you have exactly three columns in $tbl_name. You should be explicit about the columns used. Substitute the correct column names for colname1, event_name, username.

$sql = mysql_query("INSERT INTO $tbl_name (colname1, event_name, username) VALUES('','$eventname','{$_SESSION['myusername']}')");

The exact locations of SQL syntax errors will be revealed to you with some basic error checking via mysql_error().

$sql = mysql_query(<your insert statement>);
if (!$sql) {
  echo mysql_error();
}

answered May 1, 2012 at 19:14

Michael Berkowski

271k47 gold badges450 silver badges395 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user1368371 Over a year ago

I have made the changes you listed the error message states unexpected T_VARIABLE, i know this is a syntax error.

Michael Berkowski Over a year ago

If you have unexpected T_VARIABLE on the $eventname line, you probably have a syntax error on the line before that, like a missing ;.

pollirrata · Accepted Answer · 2012-05-01 19:13:51Z

1

You're missing a ' on your insert statement. Try this

INSERT INTO $tbl_name VALUES('','$eventname','$_SESSION['myusername']')

answered May 1, 2012 at 19:13

pollirrata

5,2942 gold badges35 silver badges51 bronze badges

Comments

Myb · Accepted Answer · 2017-02-02 11:54:39Z

1

Hope it help you...

$eventname=$_POST['eventname'];
$myusername = $_SESSION['myusername'];

$sql = mysql_query("INSERT INTO tbl_name VALUES('','$eventname','".$_SESSION['myusername'])."'");

echo "You have been added to the event";

edited Feb 2, 2017 at 11:54

Myb

4597 silver badges21 bronze badges

answered Feb 4, 2014 at 10:26

Phoenix

1,52817 silver badges23 bronze badges

Comments

CodeCaster · Accepted Answer · 2012-05-01 19:13:21Z

0

You need a space between $tbl_name and VALUES, and indeed a ' after $_SESSION['myusername'].

And look up SQL injection.

answered May 1, 2012 at 19:13

CodeCaster

153k24 gold badges237 silver badges287 bronze badges

Comments

SenorAmor · Accepted Answer · 2012-05-01 19:15:21Z

0

Remove the single quotes around the key in your $_SESSION array:

$sql = mysql_query("INSERT INTO $tbl_name VALUES('', '$eventname', '$_SESSION[myusername])");

answered May 1, 2012 at 19:15

SenorAmor

3,34518 silver badges27 bronze badges

Collectives™ on Stack Overflow

Insert session variable into MySQL database

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related