Threading in ASP.NET MVC 3

Question

I am currently converting a Windows Phone 7 application to its web counterpart. The application uses a big main thread from which the data is gathered, and for the moment I have just copied and pasted it as is (just a standard thread operation), in my ASP.NET MVC controller.

Sync _Sync = new Sync();
_Sync.StartSync();

The tasks work OK, but because the thread makes use of global data set from the cookies, issues arise when accessing the page with 2 different usernames. For example, if I login with "user1" in Firefox and then try to login in Chrome with another user (say "user2"), then it will automatically change the async data gathered for the first user; meaning that I will always see data pulled out from the last user logged in (regardless of the fact that I was just logged in in Firefox with another user, initially), and not each others' separate data.

In other words, the thread doesn't start separately for each individual user. How could I fix this behavior?

Does the Sync type utilize any static fields or properties for storing the user data? — Chris Shouts
– Chris Shouts, Commented May 4, 2012 at 14:57
"the thread makes use of global data set from the cookies", this doesn't sound good to me, perhaps when you create your Sync object, you can assign it a value that uniquely ties it to a specific user instead of using globals. — Matthew
– Matthew, Commented May 4, 2012 at 14:58
@ChrisShouts Yes, all the global fields needed for the sync are retained in a static object. Should I create a new instance of it every time? — ExoticCheeseSticks
– ExoticCheeseSticks, Commented May 4, 2012 at 15:02

Chris Shouts · Accepted Answer · 2012-05-04 15:12:44Z

3

Static fields and properties are shared across threads and should generally not be used to store data that pertains to a specific user or web request.

One of the following suggestions should fix your threading issues and keep your user data separate.

Create an instance of the Sync class for each request and remove any static fields / properties from the class.
Add a method to the Sync class that returns an instance of the data for a specific user instead of storing the data in static fields / properties.

answered May 4, 2012 at 15:12

Chris Shouts

5,4472 gold badges31 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ExoticCheeseSticks Over a year ago

Indeed, changing the static fields solved the problem. Thank you very much!

Collectives™ on Stack Overflow

Threading in ASP.NET MVC 3

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related