Combine two different PHP functions with the same subset of variables?

Question

Here are two example PHP functions:

function myimage1() {
global $post;
    $attachment_id = get_post_meta($post->ID, 'f1image', $single = true);
    $myimage1 = wp_get_attachment_image( $attachment_id, thumbnail );
return $myimage1;
}

(I call this one like this: <?php echo myimage1(); ?> )

and

function myimage2() {
global $post;
    $attachment_id = get_post_meta($post->ID, 'f1image', $single = true);
    $myimage2 = wp_get_attachment_image( $attachment_id, medium );
return $myimage2;
}

(I call this one like this: <?php echo myimage2(); ?> )

As you can see, both have one common variable $attachment_id. And both functions are very much related, and it's just that I don't know how to combine them both, or how to call them from the combined function.

PS: I don't know PHP, my terminology could be a bit vague. In that case, please feel free to correct me.

fuxia · Accepted Answer · 2012-05-05 12:41:29Z

2

function myimage($level) {
    global $post;
    $attachment_id = get_post_meta($post->ID, 'f1image', true);
    $myimage = wp_get_attachment_image( $attachment_id, $level );
    return $myimage;
}

myimage("medium");
myimage("thumbnail");

edited May 5, 2012 at 12:41

fuxia

63.7k6 gold badges57 silver badges64 bronze badges

answered May 5, 2012 at 8:30

Bjørn Kjos-Hanssen

7927 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

s.webbandit · Accepted Answer · 2012-05-05 08:50:53Z

0

OOP is exactly for this needs. Two functions (methods) uses the same class variable.

<?php

class A {

    public $attachment_id;

    private function wp_get_attachment_image() {

        // place your wp_get_attachment_image() function content here

    }

    public function myimage1() {

        $myimage1 = $this->wp_get_attachment_image($this->attachment_id, medium);
        return $myimage1;

    }

    public function myimage2() {

        $myimage2 = $this->wp_get_attachment_image($this->attachment_id, medium);
        return $myimage2;

    }

}

$a = new A;
$a->attachment_id = $a->get_post_meta($post->ID, 'f1image', $single = true);
$a->myimage1();
$a->myimage2();

?>

edited May 5, 2012 at 8:50

answered May 5, 2012 at 8:38

s.webbandit

17.2k17 gold badges60 silver badges82 bronze badges

1 Comment

its_me Over a year ago

This is really confusing to me. Could you please modify your example with the code in my question? Also, please provide the PHP code to call each PHP function.

Collectives™ on Stack Overflow

Combine two different PHP functions with the same subset of variables?

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related